fix: Markdown rendering in the annotation component/widget has visual issues with heading sizes#3549
Open
cursor[bot] wants to merge 1 commit intomainfrom
Open
fix: Markdown rendering in the annotation component/widget has visual issues with heading sizes#3549cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Align heading hierarchy in the annotation widget with the established pattern used in WorkflowMarkdownPreview: - h1: text-lg font-semibold (was text-base font-bold) - h2: text-base font-semibold (was text-sm font-bold) - h3: text-sm font-semibold (unchanged) - h4: text-sm font-medium (added) This fixes the visual issue where heading levels were not visually distinct, with h2 and h3 rendering at the same size. Closes #3490
|
👋 Commands for maintainers:
|
Collaborator
|
/sp start |
|
✅ Ready. Web: https://pr-3549-ephemeral.superplane.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the markdown heading size hierarchy in the annotation component/widget. Heading levels (
#,##,###) were not visually distinct —h2andh3both rendered attext-sm(14px), making the heading hierarchy unclear.Changes
Updated heading styles in
web_src/src/ui/annotationComponent/index.tsxto match the established pattern fromWorkflowMarkdownPreview:h1text-base font-bold(16px)text-lg font-semibold(18px)h2text-sm font-bold(14px)text-base font-semibold(16px)h3text-sm font-semibold(14px)text-sm font-semibold(14px, unchanged)h4text-sm font-medium(14px, added)This creates a clear visual hierarchy:
h1 > h2 > h3 > h4, consistent with other markdown rendering components in the application.Closes #3490