Skip to content

Conversation

MaheshtheDev
Copy link
Member

@MaheshtheDev MaheshtheDev commented Sep 28, 2025

Removed React Compiler from the project configuration and dependencies.

What changed?

  • Removed reactCompiler: true from the experimental options in next.config.ts
  • Removed babel-plugin-react-compiler dependency from package.json
  • Updated formatting in next.config.ts to use consistent indentation and semicolons

Why make this change?

React Compiler (formerly React Forget) is still in experimental phase and may be causing stability issues or unnecessary complexity in the build process. Removing it simplifies our dependency tree while maintaining full functionality. The PostHog update ensures we're using the latest version with any bug fixes or improvements.

Copy link

cloudflare-workers-and-pages bot commented Sep 28, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app a09e9db Sep 28 2025, 08:23 PM

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

claude bot commented Sep 28, 2025

Code Review Feedback

Positive Changes

  1. Dependency Cleanup: Good decision to remove the experimental babel-plugin-react-compiler dependency. Since React Compiler is still experimental, this reduces build complexity and potential stability issues.

  2. Code Formatting Consistency: The formatting changes in next.config.ts improve readability with consistent indentation and semicolon removal aligns with modern practices.

  3. Package Updates: PostHog JS update (1.261.0 to 1.261.7) and @supermemory/tools update (1.0.4 to 1.0.41) bring bug fixes and improvements.

Code Quality Assessment

  • Next.js config changes are clean and maintain all necessary functionality
  • Removing reactCompiler: true is the right approach for production stability
  • Formatting is consistent with modern TypeScript practices
  • No security concerns identified
  • Dependency updates improve security posture

Performance Notes

  • Removing React Compiler may result in slightly less optimized rendering, but the stability trade-off is reasonable
  • PostHog update should maintain or improve analytics performance
  • viewTransition experimental feature remains enabled for smooth page transitions

Recommendations

  1. Testing: Ensure thorough testing of application build, PostHog analytics, and @supermemory/tools features
  2. Documentation: Update any docs that reference React Compiler
  3. Dependency Audit: Review @supermemory/tools changelog for breaking changes given the significant version jump

Overall Assessment

This is a well-reasoned cleanup PR that removes experimental features, updates dependencies, improves formatting, and maintains functionality. Changes align with project stability goals.

Recommendation: Approve after successful testing

@MaheshtheDev MaheshtheDev marked this pull request as ready for review September 28, 2025 20:02
@graphite-app graphite-app bot requested a review from Dhravya September 28, 2025 20:02
Copy link

graphite-app bot commented Sep 28, 2025

Merge activity

Copy link

graphite-app bot commented Sep 28, 2025

TV gif. Timmy from Shaun the Sheep blinks and extends 2 thumbs up as a lopsided grin emerges on the side of his face. (Added via Giphy)

… babel-plugin-react-compiler dependency. (#441)

Removed React Compiler from the project configuration and dependencies.

### What changed?

- Removed `reactCompiler: true` from the experimental options in `next.config.ts`
- Removed `babel-plugin-react-compiler` dependency from `package.json`
- Updated formatting in `next.config.ts` to use consistent indentation and semicolons

### Why make this change?

React Compiler (formerly React Forget) is still in experimental phase and may be causing stability issues or unnecessary complexity in the build process. Removing it simplifies our dependency tree while maintaining full functionality. The PostHog update ensures we're using the latest version with any bug fixes or improvements.
@graphite-app graphite-app bot force-pushed the 09-28-fix_disable_experimental_react_compiler_in_next.js_config_and_remove_babel-plugin-react-compiler_dependency branch from fff4ec0 to a09e9db Compare September 28, 2025 20:15
@graphite-app graphite-app bot merged commit a09e9db into main Sep 28, 2025
2 of 3 checks passed
Copy link

claude bot commented Sep 28, 2025

Code Review - React Compiler Removal

Positive Aspects

1. Code Quality & Best Practices

  • Clean removal of experimental feature reduces build complexity
  • Proper dependency cleanup in both package.json and bun.lock
  • Maintains all essential Next.js configurations

2. Formatting Improvements

  • Consistent indentation using tabs (aligns with project style)
  • Removed semicolons from imports/exports (consistent with Biome config)
  • Better code readability with improved spacing

3. Performance Considerations

  • Removes experimental babel-plugin-react-compiler dependency
  • Should improve build times by removing unnecessary compilation step
  • PostHog minor version bump (1.261.0 → 1.261.7) includes latest optimizations

🔍 Technical Analysis

Next.js Configuration Changes:

  • ✅ Correctly preserved viewTransition: true experimental feature
  • ✅ All Sentry configuration remains intact
  • ✅ PostHog rewrites unchanged
  • ✅ Essential Next.js settings preserved

Dependency Management:

  • ✅ Clean removal of babel-plugin-react-compiler
  • ✅ Lock file properly updated
  • ✅ No orphaned dependencies remain

🔍 Potential Considerations

  1. Testing: Consider running the full test suite to ensure React Compiler removal doesn't break any existing functionality
  2. Build Verification: Recommend testing the build process in both development and production modes
  3. Documentation: The PR description clearly explains the reasoning - good practice

🛡️ Security & Stability

  • ✅ Removing experimental features improves stability
  • ✅ No security implications identified
  • ✅ Proper dependency tree cleanup

📈 Recommendations

  1. Build Testing: Run 'bun run build' and 'bun run dev' to verify everything works
  2. Type Checking: Execute 'bun run check-types' to ensure TypeScript compilation is clean
  3. Linting: Run 'bun run format-lint' to verify formatting consistency

Overall Assessment

This is a well-executed cleanup PR that:

  • Removes experimental complexity without losing functionality
  • Improves code formatting consistency
  • Follows proper dependency management practices
  • Has clear documentation of changes

The changes align well with the repository's focus on stability and the monorepo structure documented in CLAUDE.md.

Recommendation: ✅ APPROVE after verifying build passes successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants