Add support for passing a pre-created SQLAlchemy engine to Client #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A simple but extremely useful feature adding support for initializing the vecs client with a pre-build SQLAlchemy engine. This way we can utilize secure connection methods instead of just the connection string. See the discussion linked below for details.
What is the current behavior?
Please link any relevant issues here:
Supabase issue supabase/vecs#111 comment
What is the new behavior?
Client.__init__now accepts an optional SQLAlchemyengine.create_clientcan take eitherconnection_stringorengine.