Skip to content

fix: Replace bind params with f-string for arguments passing on SET c… #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Replace bind params with f-string for arguments passing on SET c… #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/vecs/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def _create_if_not_exists(self):
Collection: The found or created collection.
"""
query = text(
f"""
"""
select
relname as table_name,
atttypmod as embedding_dim
Expand Down Expand Up @@ -556,15 +556,9 @@ def query(
with self.client.Session() as sess:
with sess.begin():
# index ignored if greater than n_lists
sess.execute(
text("set local ivfflat.probes = :probes").bindparams(probes=probes)
)
sess.execute(text(f"set local ivfflat.probes = {probes}"))
if self.client._supports_hnsw():
sess.execute(
text("set local hnsw.ef_search = :ef_search").bindparams(
ef_search=ef_search
)
)
sess.execute(text(f"set local hnsw.ef_search = {ef_search}"))
if len(cols) == 1:
return [str(x) for x in sess.scalars(stmt).fetchall()]
return sess.execute(stmt).fetchall() or []
Expand Down Expand Up @@ -780,7 +774,9 @@ def create_index(

if method == IndexMethod.ivfflat:
if not index_arguments:
n_records: int = sess.execute(func.count(self.table.c.id)).scalar() # type: ignore
n_records: int = sess.execute(
func.count(self.table.c.id)
).scalar() # type: ignore

n_lists = (
int(max(n_records / 1000, 30))
Expand Down