fix: subscriptions error rate limit #1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgurgel
changed the title
edgurgel
force-pushed
the
fix/subscriptions-rate-limit
branch
from
42b849b to
3bf7a2a
Compare
This comment has been minimized.
This comment has been minimized.
edgurgel
force-pushed
the
fix/subscriptions-rate-limit
branch
from
5ec0559 to
59a2ece
Compare
filipecabaco
approved these changes
Oct 31, 2025
This comment has been minimized.
This comment has been minimized.
Member
|
🎉 This PR is included in version 2.58.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Apply rate limits to CdcRls subscription creation similar to how we do it for RLS checks on the Authorization module.
This not only avoids unnecessary RPC calls but also it gives time for the tenant database to reset their DB connection to then start accepting subscriptions again.
I've also decreased the rate counter idle shutdown to 10 minutes as 15 minutes is a looong time if there is low activity coming from a tenant.
Additional context
Add any other context or screenshots.