fix: invalid PG changes subscriptions should not retry #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipecabaco
approved these changes
Oct 28, 2025
edgurgel
force-pushed
the
fix/pg-changes-subscription-error-part-2
branch
2 times, most recently
from
e200edd to
38b0a47
Compare
* Table that does not exist * Realtime publication does not exist * Column does not exist
edgurgel
force-pushed
the
fix/pg-changes-subscription-error-part-2
branch
from
38b0a47 to
a248cf1
Compare
Member
|
🎉 This PR is included in version 2.57.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It will not retry for:
And any other unrecoverable* errors when inserting subscriptions. I think it's fair to expect people to reconnect if they changed a table or add a new table.
What is the current behavior?
We keep retrying ad-infinitum
What is the new behavior?
We only retry for temporary errors like RPC timeouts or database timeouts
Additional context
Add any other context or screenshots.