Skip to content

Cleanup go version management by taking go version from go.mod #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

avakarev
Copy link

@avakarev avakarev commented May 11, 2025

Additionally, remove unused strategy-matrix from test job

What kind of change does this PR introduce?

Github workflow actions cleanup

What is the current behavior?

Job actions/setup-go@v5 takes go version to install from the provided string literal

What is the new behavior?

Job actions/setup-go@v5 take go version from go.mod

Additional context

Now there are less things to maintain and less changes need to be done on go version bump.
Additionally, unused strategy-matrix from test job is removed.

….mod

Additionally, remove unused strategy-matrix from test job.
@avakarev avakarev requested a review from a team as a code owner May 11, 2025 18:15
Copy link
Contributor

@cstockton cstockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot @avakarev

@avakarev
Copy link
Author

Looks good to me, thanks a lot @avakarev

It failed because setup-go struggled to find go.mod before checkout placed it to the filesystem. Fixed the action order, please approve pipeline to re-run.

@avakarev avakarev requested a review from cstockton May 21, 2025 13:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15025666501

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.643%

Totals Coverage Status
Change from base Build 15005507419: 0.0%
Covered Lines: 10952
Relevant Lines: 15726

💛 - Coveralls

@cstockton cstockton self-requested a review June 5, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants