Repository navigation
fix(realtime): correct channel removal and token refresh - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
remove_all_channelscalled its own Registry throughunsubscribe, causing an immediate:calling_selfexit instead of leaving the channels.Solution
leaving, cancel its rejoin timers and process the batch inhandle_continue, reusing the existing leave behavior without a self-call.access_token_fnduring a healthy heartbeat; persist and push only a changed callback token to joined channels.realtime-ex.Rationale
Continuation-based removal preserves the existing connected and disconnected leave semantics without nested GenServer calls. Refreshing only callback tokens on the heartbeat send path avoids extra pushes for static or manual tokens and leaves timeout, reconnection and telemetry behavior unchanged. This PR excludes deferred realtime work and does not release the package.