Optimize textures & fix blocks being white when running Sky Aesthetics/Stellaris#1
Open
ElementW wants to merge 2 commits into
Open
Optimize textures & fix blocks being white when running Sky Aesthetics/Stellaris#1ElementW wants to merge 2 commits into
ElementW wants to merge 2 commits into
Conversation
Not only is blend-less render slightly faster, enabling blend made renderBlockSkybox subject to whatever blend mode was set up prior, which depends on mods runnning prior to Shadered in the render loop. For instance, the Sky Aesthetics mods, through things like Stellaris, renders celestial bodies and changes the blend mode to one that makes the skybox blocks appear solid white. (See st0x0ef/stellaris#200) Skyboxes are always fully opaque, so remove the blend altogether.
Ran the PNGs through pngquant & zopflipng. The former does technically reduce the image quality by constraining the PNGs to a palette of 256 colors, but dithering is applied, and the color depth loss is not very perceptible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing a PR here with the hopes it gets bundled in with Noodlegamer76#12
If you don't think the texture optimize pass should be included, feel free to cherry-pick the render fix commit and close this PR.