Proper support for java apps #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The failing check isn't from code i have changed fyi |
Android Studio doesn't like this to be set
This makes it so the custom color function does not interfere with the java color function.
deadman96385
force-pushed
the
master
branch
2 times, most recently
from
7186a60 to
cbd26a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current library only partially works in Java because there is a function that is already called color in java so it takes priority over this custom one. I have refactored the function to a new name. I have also updated the readme to add a java example of non-async generation of the QR. If you could add an Async example that would be great I couldn't figure out how to get it working.