some updates for 2021 - #1
Draft
brody2consult wants to merge 17 commits into
Draft
Conversation
added 17 commits
February 4, 2021 17:30
BREAKING CHANGE
and update imports as needed
and add a @ts-ignore / TODO comment to: src/__tests__/withHanders-test.tsx
- @types/enzyme -> ^3.10.8 - @types/jest -> ^26.0.20 - @types/recompose -> ^0.30.7
- enzyme -> ^3.11.0 - enzyme-adapter-react-16 -> ^1.15.6
- react -> ~16.12.0 - react-dom -> ~16.12.0
Note that formatting of the build by Prettier 1.17.1 does not seem to be changed by this update.
to resolve a type issue with @types/react post-16.4 update: error TS2322: Type 'ComponentClass<OuterProps>' is not assignable to type 'ComponentClass<OuterProps, any>'.
brody2consult
commented
Feb 5, 2021
brody2consult
left a comment
brody2consult
left a comment
Author
There was a problem hiding this comment.
Some code & test TODO comments
Comment on lines
+60
to
62
| // TODO resolve type issue here with @types/react post-16.4 update: | ||
| // error TS2322: Type 'ComponentClass<OuterProps>' is not assignable to type 'ComponentClass<OuterProps, any>'. | ||
| return compose<InnerProps, OuterProps>(...this.opts)(Component); |
Author
There was a problem hiding this comment.
I would like to get the type issue resolved here with the @types/react post-16.4 update.
| trueEnhancer: | ||
| | ComponentEnhancer<InnerProps, NextProps> | ||
| | InferableComponentEnhancer<NextProps> | ||
| | InferableComponentEnhancer<{}> |
Author
There was a problem hiding this comment.
I think it would be ideal to get recompose to allow InferableComponentEnhancer<NextProps> type option in its exported .d.ts.
| falseEnhancer?: | ||
| | ComponentEnhancer<InnerProps, NextProps> | ||
| | InferableComponentEnhancer<NextProps> | ||
| | InferableComponentEnhancer<{}> |
Author
There was a problem hiding this comment.
ditto:
I think it would be ideal to get
recomposeto allowInferableComponentEnhancer<NextProps>type option in its exported.d.ts.
Comment on lines
+56
to
57
| // @ts-ignore - TODO: | ||
| expect(component.firstCall.args[0].handler).toBe(component.secondCall.args[0].handler); |
Author
There was a problem hiding this comment.
I would like to get this TODO resolved at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branch()to work with TypeScript post-2.xjest&ts-jest, update the configuration, and update some imports in the test code@ts-ignore& TODO commentsSome TODO items:
tslintwitheslint, ideally with "Standard JS" linting rules & Prettier code formatting