Skip to content

Conversation

@shubham6822
Copy link
Contributor


name: Update HashRouter to BrowserRouter
about: implement BrowserRouter for clean links and better SEO

Description

This PR updates the app’s routing from HashRouter to BrowserRouter for cleaner URLs and improved SEO. Previously, the app used HashRouter, which added a # in the URL, resulting in unclean links that aren’t ideal for search engine indexing. With BrowserRouter, the URLs are now more readable and SEO-friendly.

Related Issue

This PR fixes #52

Changes Made

-Replaced createHashRouter with createBrowserRouter in routes.tsx.
-Ensured all routes remain unchanged while eliminating the hash fragment from URLs.

Testing Performed

  • The code builds successfully
  • all changed files are linted using `npm run format: file

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes for Reviewers

Now you can see there was no # in link
Here Deploy Url https://shubham6822.github.io/www-v2

@sa-fw-an
Copy link
Member

This commit d17cae6 fixes the issue

@sa-fw-an sa-fw-an closed this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants