Skip to content

Conversation

@Dakshsharma1108
Copy link
Contributor

@Dakshsharma1108 Dakshsharma1108 commented Nov 17, 2025


name: Pull Request
about: Submit changes to the Sugar Labs website for review

📝 Description

1.Added some text color properties for dark mode.
2. added some hover effect for dark mode.
3. added some text and border properties for blockcode in markdownrenderer.jsx for darkmode.
4. change hover property for back button for darkmode.
5. Lightmode has not effected by changes nor the other files
6. Changes are also visible in screenshots

🔗 Related Issue

Fixes #544
Fixes #557

🔄 Type of Change

  • 🎨 UI/UX Update (visual changes, styling improvements)
  • 🐛 Bug Fix
  • ⚡ Performance Improvement

📷 Visual Changes

Before before1 before2 before3
After the changes after1 after2 after3

🧪 Testing Performed

📱 Browser Compatibility

  • Chrome (Version: )
  • Firefox (Version: )
  • Safari (Version: )
  • Edge (Version: )
  • Mobile Chrome (Device: )
  • Mobile Safari (Device: )

🖥️ Responsive Design

  • Desktop (1200px+)
  • Tablet (768px - 1199px)
  • Mobile (320px - 767px)

✅ Test Cases

.

♿ Accessibility

  • Proper heading hierarchy maintained
  • ARIA labels added where needed
  • Color contrast requirements met
  • Keyboard navigation works correctly
  • Screen reader testing performed

📋 PR Checklist

  • My code follows the project's coding style guidelines
  • I have tested these changes locally
  • I have updated the documentation accordingly
  • My changes generate no new warnings or console errors
  • I have added tests that prove my fix/feature works
  • All existing tests pass successfully
  • I have checked for and resolved any merge conflicts
  • I have optimized images/assets (if applicable)
  • I have validated all links are working correctly

💭 Additional Notes


📚 Reviewer Resources

Thank you for contributing to the Sugar Labs website! 🎉

@github-actions
Copy link

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@Dakshsharma1108
Copy link
Contributor Author

please review this @sa-fw-an

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visiblity issues Text Not Visible in Dark Theme (Low Contrast Issue)

1 participant