Fix/avatar shape #562
Open
Fix/avatar shape #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
Contributor
Author
|
@sa-fw-an please review this |
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Submit changes to the Sugar Labs website for review
📝 Description
This PR fixes an issue where the user avatar inside the testimonial card becomes distorted and loses its circular shape when the text content increases.
The problem was caused by the image being allowed to shrink inside a flex container, causing the circle to stretch into an oval.
The fix adds shrink-0 to both the image and fallback avatar containers so they maintain a fixed 1:1 ratio at all times.
🔗 Related Issue
Fixes #560
🔄 Type of Change
📷 Visual Changes
Screenshots / GIFs
Before
after
🧪 Testing Performed
📱 Browser Compatibility
🖥️ Responsive Design
✅ Test Cases
Long username — avatar remains circular
Long testimonial text — avatar remains stable
Image load error — fallback avatar stays circular
♿ Accessibility
📋 PR Checklist
💭 Additional Notes
If the team prefers another approach (e.g., setting fixed aspect-ratio), I can update the implementation.
Feel free to suggest any improvements.
📚 Reviewer Resources
Thank you for contributing to the Sugar Labs website! 🎉