Skip to content

Feat: enhance dark mode support and improve styling for MorePage #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat: enhance dark mode support and improve styling for MorePage #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 33 additions & 5 deletions src/pages/More.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const MorePage: React.FC = () => {
const [pagesByCategory, setPagesByCategory] = useState<
Record<string, MorePageType[]>
>({});
const [isDarkMode, setIsDarkMode] = useState(false);
const [activeCategory, setActiveCategory] = useState<string>('All');
const [notFoundSlug, setNotFoundSlug] = useState<string | null>(null);
const [zoomableImages, setZoomableImages] = useState<HTMLImageElement[]>([]);
Expand All @@ -28,6 +29,20 @@ const MorePage: React.FC = () => {
alt: string;
} | null>(null);

useEffect(() => {
const dark = document.documentElement.classList.contains('dark');
setIsDarkMode(dark);

const observer = new MutationObserver(() => {
const updatedDark = document.documentElement.classList.contains('dark');
setIsDarkMode(updatedDark);
});

observer.observe(document.documentElement, { attributes: true });

return () => observer.disconnect();
}, []);

useEffect(() => {
const loadPage = async () => {
setIsLoading(true);
Expand All @@ -45,7 +60,7 @@ const MorePage: React.FC = () => {
if (fetchedPage) {
setPage(fetchedPage);
setNotFoundSlug(null);
document.title = fetchedPage.title + ' - Sugar Labs';
document.title = `${fetchedPage.title} - Sugar Labs`;

if (fetchedPage.category) {
setActiveCategory(fetchedPage.category);
Expand Down Expand Up @@ -132,7 +147,11 @@ const MorePage: React.FC = () => {
className="text-blue-600 hover:underline mb-2 inline-block"
>
<motion.button
className="mb-6 px-4 py-2 flex items-center text-blue-600 hover:text-blue-700 transition-colors rounded-md hover:bg-blue-50"
className={
'mb-6 px-4 py-2 flex items-center text-blue-600 ' +
'hover:text-blue-700 transition-colors rounded-md ' +
'hover:bg-blue-50'
}
whileHover={{ scale: 1.05 }}
whileTap={{ scale: 0.95 }}
>
Expand Down Expand Up @@ -184,7 +203,7 @@ const MorePage: React.FC = () => {
<h3 className="font-bold text-xl mb-4">
{activeCategory === 'All'
? 'All Pages'
: activeCategory + ' Pages'}
: `${activeCategory} Pages`}
</h3>
<ul className="space-y-2">
{pagesByCategory[activeCategory]?.map((linkPage) => (
Expand Down Expand Up @@ -213,7 +232,11 @@ const MorePage: React.FC = () => {
transition={{ duration: 0.5 }}
key={page?.slug}
>
<div className="bg-white rounded-lg shadow-md p-6">
<div
className={`${
isDarkMode ? 'bg-amber-950' : 'bg-white'
} rounded-lg shadow-md p-6`}
>
{page ? (
<div className="prose prose-lg max-w-none">
<MarkdownRenderer
Expand Down Expand Up @@ -297,7 +320,12 @@ const MorePage: React.FC = () => {
</p>
<button
onClick={closeImageModal}
className="absolute top-2 right-2 text-white text-2xl hover:text-gray-300 bg-black bg-opacity-50 rounded-full w-8 h-8 flex items-center justify-center focus:outline-none focus:ring-2 focus:ring-white"
className={
'absolute top-2 right-2 text-white text-2xl ' +
'hover:text-gray-300 bg-black bg-opacity-50 rounded-full ' +
'w-8 h-8 flex items-center justify-center ' +
'focus:outline-none focus:ring-2 focus:ring-white'
}
aria-label="Close image"
>
&times;
Expand Down