Skip to content

Conversation

@Dakshsharma1108
Copy link
Contributor


name: Pull Request
about: Submit changes to the Sugar Labs website for review

📝 Description

  1. It fixes the text visibility of more page in dark mode.
  2. remove some dark properties from non-visible text.
  3. added some text-color properties to text that are not visible.

🔗 Related Issue

Fixes #544

🔄 Type of Change

  • 🎨 UI/UX Update (visual changes, styling improvements)
  • 🐛 Bug Fix

📷 Visual Changes

Before
before

After the changes
after

🧪 Testing Performed

📱 Browser Compatibility

  • Chrome (Version: )
  • Firefox (Version: )
  • Safari (Version: )
  • Edge (Version: )
  • Mobile Chrome (Device: )
  • Mobile Safari (Device: )

🖥️ Responsive Design

  • Desktop (1200px+)
  • Tablet (768px - 1199px)
  • Mobile (320px - 767px)

✅ Test Cases

♿ Accessibility

  • Proper heading hierarchy maintained
  • ARIA labels added where needed
  • Color contrast requirements met
  • Keyboard navigation works correctly
  • Screen reader testing performed

📋 PR Checklist

  • My code follows the project's coding style guidelines
  • I have tested these changes locally
  • I have updated the documentation accordingly
  • My changes generate no new warnings or console errors
  • I have added tests that prove my fix/feature works
  • All existing tests pass successfully
  • I have checked for and resolved any merge conflicts
  • I have optimized images/assets (if applicable)
  • I have validated all links are working correctly

💭 Additional Notes


📚 Reviewer Resources

Thank you for contributing to the Sugar Labs website! 🎉

@github-actions
Copy link

❌ Checks Failed

Status: 🚫 Not ready to merge

Please fix the following issues before merging:

📝 Code Linting Failed

Issue: Code formatting or style violations detected.

Specific problems:

• Code formatting issues detected

How to fix:

Platform Command Description
🐧 Unix/macOS/Linux npm run format Auto-fix all formatting issues
🪟 Windows npm run format:file <filename> Fix specific files
🔍 Check Only npm run format:check Check formatting without fixing

Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions.


🛠️ Next Steps

  1. Fix the issues mentioned above
  2. Test locally to ensure everything works
  3. Push your fixes to this branch
  4. Wait for re-check - This bot will automatically run again

🤖 This comment will be updated automatically when you push new commits

@github-actions
Copy link

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@Dakshsharma1108
Copy link
Contributor Author

please review this @sa-fw-an

@Dakshsharma1108 Dakshsharma1108 marked this pull request as draft November 17, 2025 09:07
@Dakshsharma1108
Copy link
Contributor Author

this pr conflicting some other files so closing this and raising another

@Dakshsharma1108 Dakshsharma1108 deleted the fix/fixes-text branch November 17, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text Not Visible in Dark Theme (Low Contrast Issue)

1 participant