-
Notifications
You must be signed in to change notification settings - Fork 125
Update HashRouter to BrowserRouter #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR does not work on GH pages when deployed. Make sure it works when deployed on your fork and all the links work |
|
I don't get what you mean; build was prefect, there was no conflicts |
Yes. Deploy it. Links do not work |
|
|
I cannot see the depolyed site. I can see is just a white screen |
|
You have made more than 15 notifications to all Sugar Labs organisation members in a few hours; this is too much. Please work in your own branch until you are ready to make a pull request, thanks. |
|
@shubham6822 This is not the way to handle commits. If you want to make a commit, please work on your fork and, whenever you are done, raise a PR. I'll be closing this PR. Whenever you are ready with the implemented task, raise a new PR. If you have any doubts, contact me. |
|
Sorry, I don't get it why this thing are not work on GH page deployment Screencast.from.2025-03-18.14-01-24.webm |
That is the trick with BrowserRouter in GH Pages. One way is you could use basename of the repo in |
ok |


name: Update HashRouter to BrowserRouter
about: implement BrowserRouter for clean links and better SEO
Description
This PR updates the app’s routing from HashRouter to BrowserRouter for cleaner URLs and improved SEO. Previously, the app used HashRouter, which added a # in the URL, resulting in unclean links that aren’t ideal for search engine indexing. With BrowserRouter, the URLs are now more readable and SEO-friendly.
Related Issue
This PR fixes #52
Changes Made
-Replaced createHashRouter with createBrowserRouter in routes.tsx.
-Ensured all routes remain unchanged while eliminating the hash fragment from URLs.
Testing Performed
Checklist
Additional Notes for Reviewers
Now you can see there was no # in link
https://github.com/user-attachments/assets/71a29e8e-71a5-4902-9f10-5226afda27af