Skip to content

Conversation

@sandeeprudola
Copy link

πŸ› οΈ Fix: Dark Mode Flicker and Overflow Issue
πŸ”— Related Issue
Fixes #499

✨ Summary
This PR fixes UI/UX issues related to:

πŸŒ“ Dark Mode Toggle: Removed flicker and improved transition animation
πŸ“ Layout Overflow: Adjusted layout to prevent unwanted scroll/overflow behavior.

πŸ§ͺ How to Test
Run the app locally (npm run dev)
Toggle between Dark and Light mode β€” the flicker should be gone
Check the layout for overflow or scroll inconsistencies

βœ… Checklist
Verified build β€” npm run build successful
Passed linting β€” npm run lint:ts
Code formatted β€” npm run format
Verified UI on both light/dark modes

πŸ’¬ Additional Notes
Follows TypeScript conventions and linting rules
Commit message uses Conventional Commits format (fix(ui): ...)
Changes are scoped and do not affect unrelated components

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

❌ Checks Failed

Status: 🚫 Not ready to merge

Please fix the following issues before merging:

πŸ“ Code Linting Failed

Issue: Code formatting or style violations detected.

Specific problems:

β€’ Code formatting issues detected

How to fix:

Platform Command Description
🐧 Unix/macOS/Linux npm run format Auto-fix all formatting issues
πŸͺŸ Windows npm run format:file <filename> Fix specific files
πŸ” Check Only npm run format:check Check formatting without fixing

Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions.


πŸ› οΈ Next Steps

  1. Fix the issues mentioned above
  2. Test locally to ensure everything works
  3. Push your fixes to this branch
  4. Wait for re-check - This bot will automatically run again

πŸ€– This comment will be updated automatically when you push new commits

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

❌ Checks Failed

Status: 🚫 Not ready to merge

Please fix the following issues before merging:

πŸ“ Code Linting Failed

Issue: Code formatting or style violations detected.

Specific problems:

β€’ Code formatting issues detected

How to fix:

Platform Command Description
🐧 Unix/macOS/Linux npm run format Auto-fix all formatting issues
πŸͺŸ Windows npm run format:file <filename> Fix specific files
πŸ” Check Only npm run format:check Check formatting without fixing

Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions.


πŸ› οΈ Next Steps

  1. Fix the issues mentioned above
  2. Test locally to ensure everything works
  3. Push your fixes to this branch
  4. Wait for re-check - This bot will automatically run again

πŸ€– This comment will be updated automatically when you push new commits

@jagpreetrahi
Copy link

jagpreetrahi commented Nov 3, 2025

Hey @sandeeprudola , i would like to suggest a solution to pass all the checks of this PR.

Issue related to prettier formatting checks.

So you have to fix the following files
src/App.tsx

src/components/shared/DarkModeToggle.tsx
src/pages/News/NewsPage.tsx

Or directly run the prettier command
with --write to fix.

@sandeeprudola
Copy link
Author

hey @jagpreetrahi I have fixed the linting issues on the next pr #527 this pr have all the check passed, thanks for the concern

@sa-fw-an sa-fw-an closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI/UX inconsistencies across various sections (toggle, scrolling, text alignment, shadows, and truncation)

3 participants