Skip to content

fixes some positions of elements in header #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fixes some positions of elements in header #520

wants to merge 3 commits into from

Conversation

@Dakshsharma1108
Copy link
Contributor

@Dakshsharma1108 Dakshsharma1108 commented Nov 1, 2025

name: Pull Request
about: Submit changes to the Sugar Labs website for review

📝 Description

it will fix some position of element in header like toggle and try now button.
before these elements overlaping each other but after this it will this problem.

🔗 Related Issue

solves Part of #499

🔄 Type of Change

  • 🎨 UI/UX Update (visual changes, styling improvements)
  • 🐛 Bug Fix

📷 Visual Changes

Before
image
After making changes
image

🧪 Testing Performed

📱 Browser Compatibility

  • [ ]Operating System: Windows 10
  • [ ]Browser: Chrome
  • [ ]Screen resolution: 1920x1080
  • [ ]Version: 118.0.5993.117

🖥️ Responsive Design

  • Desktop width(1024-1224)

✅ Test Cases

  1. change of screen sizes

♿ Accessibility

  • Proper heading hierarchy maintained
  • ARIA labels added where needed
  • Color contrast requirements met
  • Keyboard navigation works correctly
  • Screen reader testing performed

📋 PR Checklist

  • My code follows the project's coding style guidelines
  • I have tested these changes locally
  • I have updated the documentation accordingly
  • My changes generate no new warnings or console errors
  • I have added tests that prove my fix/feature works
  • All existing tests pass successfully
  • I have checked for and resolved any merge conflicts
  • I have optimized images/assets (if applicable)
  • I have validated all links are working correctly

💭 Additional Notes

📚 Reviewer Resources

Thank you for contributing to the Sugar Labs website! 🎉

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@Dakshsharma1108
Copy link
Contributor Author

Dakshsharma1108 commented Nov 2, 2025

please review this pr @sa-fw-an @pikurasa

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

sa-fw-an
sa-fw-an reviewed Nov 3, 2025
View reviewed changes
package-lock.json
Copy link
Member

@sa-fw-an sa-fw-an Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only push files that you have made changes to. Do not push files that you have not touched.

Copy link
Contributor Author

@Dakshsharma1108 Dakshsharma1108 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was done by last commit
@sa-fw-an

Copy link
Contributor Author

@Dakshsharma1108 Dakshsharma1108 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remove the changes that i made in package-lock

Copy link
Member

@sa-fw-an sa-fw-an Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cherry pick the commit and then push it. Or Raise a seperate PR.

Copy link
Contributor Author

@Dakshsharma1108 Dakshsharma1108 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it raising another pr and closing this one

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@Dakshsharma1108 Dakshsharma1108 deleted the feature/fixes-header branch November 3, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sa-fw-an sa-fw-an sa-fw-an left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dakshsharma1108 @sa-fw-an