-
Notifications
You must be signed in to change notification settings - Fork 120
feat: Add authors page to list all contributors #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Checks Failed
Please fix the following issues before merging: 📝 Code Linting FailedIssue: Code formatting or style violations detected. Specific problems: • Code formatting issues detected How to fix:
Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions. 🛠️ Next Steps
|
ca2e50b to
211189c
Compare
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
|
@lokeshjatoth Instead of having a single author in each line , probably make it dynamic and add 3 or 4 authors.. making it more like a grid based layout instead of the list based layout. |
211189c to
2175f70
Compare
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
|
Hi @sa-fw-an, I've updated the PR with the grid layout as you suggested. Please let me know if these changes look good.
|
@lokeshjatoth Can you add like this type of design for the |
2175f70 to
0e5193b
Compare
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
0e5193b to
e16b073
Compare
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
|
Hi @sa-fw-an, thanks for the great feedback! I've just pushed an update that implements the new header and description style, matching the design from the Leadership page as you suggested. Here's a screenshot of how it looks now:
Let me know what you think! |
e16b073 to
7caa216
Compare
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
src/routes.tsx
Outdated
| import Matrix from '@/pages/Matrix'; | ||
| import NotFoundPage from '@/pages/NotFoundPage'; | ||
| import Contributors from '@/pages/Contributors'; | ||
| import AuthorsPage from './pages/News/AuthorsPage'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the @ for imports instead of the .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I include Authors section in the About drop down?
e16b073 to
ceddb06
Compare
❌ Checks Failed
Please fix the following issues before merging: 📝 Code Linting FailedIssue: Code formatting or style violations detected. Specific problems: • Code formatting issues detected How to fix:
Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions. 🛠️ Next Steps
|
ceddb06 to
e60f5fd
Compare
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
|
Is that Okay? |
|
@lokeshjatoth Looks Amazing. Great Work :) |



Fixes #513
📝 Description
This PR fixes the blank page at
/authorsby creating a new, dedicated "Meet Our Authors" page.This new page (
AuthorsPage.tsx) fetches the list of all authors fromauthor-utils.ts, displays them in a series of cards, and includes quick stats like their post count. Each card is clickable and links to that author's individual profile page, providing the central author directory that was missing.🔗 Related Issue
Fixes #513
🔄 Type of Change
📷 Visual Changes
Screenshot
🧪 Testing Performed
📱 Browser Compatibility
🖥️ Responsive Design
✅ Test Cases
npm run dev./authorspage in your browser./authors/aditya-singh).♿ Accessibility
📋 PR Checklist
💭 Additional Notes
This PR adds
src/pages/News/AuthorsPage.tsx(the new page component) and modifiessrc/routes.tsxto add the new route.