Skip to content

Conversation

@lokeshjatoth
Copy link
Contributor

@lokeshjatoth lokeshjatoth commented Oct 31, 2025

Fixes #513

📝 Description

This PR fixes the blank page at /authors by creating a new, dedicated "Meet Our Authors" page.

This new page (AuthorsPage.tsx) fetches the list of all authors from author-utils.ts, displays them in a series of cards, and includes quick stats like their post count. Each card is clickable and links to that author's individual profile page, providing the central author directory that was missing.

🔗 Related Issue

Fixes #513

🔄 Type of Change

  • 📱 New Feature (new page, component, or functionality)
  • 🎨 UI/UX Update (visual changes, styling improvements)
  • 📖 Content Update (text changes, documentation)
  • 🐛 Bug Fix
  • ⚡ Performance Improvement
  • ♿ Accessibility Enhancement
  • 🔒 Security Update
  • 📦 Dependency Update
  • 🧹 Code Refactoring
  • 🧪 Test Updates

📷 Visual Changes

Screenshot image image

🧪 Testing Performed

📱 Browser Compatibility

  • Chrome (Version: )
  • Firefox (Version: )
  • Safari (Version: )
  • Edge (Version: )
  • Mobile Chrome (Device: )
  • Mobile Safari (Device: )

🖥️ Responsive Design

  • Desktop (1200px+)
  • Tablet (768px - 1199px)
  • Mobile (320px - 767px)

✅ Test Cases

  1. Run npm run dev.
  2. Navigate to the /authors page in your browser.
  3. Verify: The "Meet Our Authors" page loads correctly (it is not a blank screen).
  4. Verify: A list of author cards is displayed.
  5. Verify: Each card correctly shows the author's avatar, name, title, and total post count.
  6. Verify: Click on an author card. You should be redirected to that specific author's individual profile page (e.g., /authors/aditya-singh).

♿ Accessibility

  • Proper heading hierarchy maintained
  • ARIA labels added where needed
  • Color contrast requirements met
  • Keyboard navigation works correctly
  • Screen reader testing performed

📋 PR Checklist

  • My code follows the project's coding style guidelines
  • I have tested these changes locally
  • I have updated the documentation accordingly
  • My changes generate no new warnings or console errors
  • I have added tests that prove my fix/feature works
  • All existing tests pass successfully
  • I have checked for and resolved any merge conflicts
  • I have optimized images/assets (if applicable)
  • I have validated all links are working correctly

💭 Additional Notes

This PR adds src/pages/News/AuthorsPage.tsx (the new page component) and modifies src/routes.tsx to add the new route.


@github-actions
Copy link

❌ Checks Failed

Status: 🚫 Not ready to merge

Please fix the following issues before merging:

📝 Code Linting Failed

Issue: Code formatting or style violations detected.

Specific problems:

• Code formatting issues detected

How to fix:

Platform Command Description
🐧 Unix/macOS/Linux npm run format Auto-fix all formatting issues
🪟 Windows npm run format:file <filename> Fix specific files
🔍 Check Only npm run format:check Check formatting without fixing

Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions.


🛠️ Next Steps

  1. Fix the issues mentioned above
  2. Test locally to ensure everything works
  3. Push your fixes to this branch
  4. Wait for re-check - This bot will automatically run again

🤖 This comment will be updated automatically when you push new commits

@lokeshjatoth lokeshjatoth force-pushed the feat/add-authors-page branch from ca2e50b to 211189c Compare October 31, 2025 15:49
@github-actions
Copy link

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@sa-fw-an
Copy link
Member

@lokeshjatoth Instead of having a single author in each line , probably make it dynamic and add 3 or 4 authors.. making it more like a grid based layout instead of the list based layout.

@lokeshjatoth lokeshjatoth force-pushed the feat/add-authors-page branch from 211189c to 2175f70 Compare October 31, 2025 17:26
@github-actions
Copy link

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@lokeshjatoth
Copy link
Contributor Author

Hi @sa-fw-an,

I've updated the PR with the grid layout as you suggested. Please let me know if these changes look good.

image

@sa-fw-an
Copy link
Member

sa-fw-an commented Nov 3, 2025

Screenshot 2025-11-03 at 7 22 48 PM

@lokeshjatoth Can you add like this type of design for the Meet Our Authors and then some description?
Rest all looks great. Great Work :)

@lokeshjatoth lokeshjatoth force-pushed the feat/add-authors-page branch from 2175f70 to 0e5193b Compare November 3, 2025 14:42
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@lokeshjatoth lokeshjatoth force-pushed the feat/add-authors-page branch from 0e5193b to e16b073 Compare November 3, 2025 14:53
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@lokeshjatoth
Copy link
Contributor Author

Hi @sa-fw-an, thanks for the great feedback!

I've just pushed an update that implements the new header and description style, matching the design from the Leadership page as you suggested.

Here's a screenshot of how it looks now:

image

Let me know what you think!

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@lokeshjatoth lokeshjatoth reopened this Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

src/routes.tsx Outdated
import Matrix from '@/pages/Matrix';
import NotFoundPage from '@/pages/NotFoundPage';
import Contributors from '@/pages/Contributors';
import AuthorsPage from './pages/News/AuthorsPage';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the @ for imports instead of the .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I include Authors section in the About drop down?

@lokeshjatoth lokeshjatoth force-pushed the feat/add-authors-page branch from e16b073 to ceddb06 Compare November 4, 2025 15:21
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

❌ Checks Failed

Status: 🚫 Not ready to merge

Please fix the following issues before merging:

📝 Code Linting Failed

Issue: Code formatting or style violations detected.

Specific problems:

• Code formatting issues detected

How to fix:

Platform Command Description
🐧 Unix/macOS/Linux npm run format Auto-fix all formatting issues
🪟 Windows npm run format:file <filename> Fix specific files
🔍 Check Only npm run format:check Check formatting without fixing

Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions.


🛠️ Next Steps

  1. Fix the issues mentioned above
  2. Test locally to ensure everything works
  3. Push your fixes to this branch
  4. Wait for re-check - This bot will automatically run again

🤖 This comment will be updated automatically when you push new commits

@lokeshjatoth lokeshjatoth force-pushed the feat/add-authors-page branch from ceddb06 to e60f5fd Compare November 4, 2025 15:27
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@lokeshjatoth
Copy link
Contributor Author

Is that Okay?

@sa-fw-an
Copy link
Member

sa-fw-an commented Nov 5, 2025

@lokeshjatoth Looks Amazing. Great Work :)

@sa-fw-an sa-fw-an merged commit 1affcca into sugarlabs:main Nov 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show authors from https://www.sugarlabs.org/authors/

2 participants