Skip to content

Conversation

@Ubayed-Bin-Sufian
Copy link
Contributor

Summary for PR:

This PR adds a step-by-step guide on how to add and modify favicons in the project. The Favicon.md file includes instructions for adding a new favicon, updating the favicon list in Randomfavicon.js, and modifying the colors of existing favicons by changing hex codes in the SVG files.

@sa-fw-an
Copy link
Member

@Ubayed-Bin-Sufian I suggest renaming the file to Adding_favicon for a better understanding of the file's purpose by just seeing its name.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

@Ubayed-Bin-Sufian I suggest renaming the file to Adding_favicon for a better understanding of the file's purpose by just seeing its name.

Please have a look.

@sa-fw-an sa-fw-an merged commit 1e6eac6 into sugarlabs:main Feb 18, 2025
@Ubayed-Bin-Sufian Ubayed-Bin-Sufian deleted the favicon branch February 18, 2025 18:10
@chimosky
Copy link
Member

chimosky commented Feb 18, 2025

It'll be nice to have those tests pass before merging, that's why you have the workflows.

Especially in some scenarios like the error in the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants