-
Notifications
You must be signed in to change notification settings - Fork 124
Dark mode Blog Post #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode Blog Post #468
Conversation
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
|
@sa-fw-an plz review |
pikurasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all needs to be on a clean branch. Please submit a new PR.
Please also address comments to your writing.
| # Adding Dark Mode to a Sugar Labs Website | ||
|
|
||
| ## Introduction | ||
| Sugar Labs builds open-source tools that make learning playful and accessible. I recently contributed dark mode to a Sugar Labs web project. This post outlines the problem I encountered, how I debugged and fixed it, and the key lessons I learned so others can ship accessible theming with confidence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open-source --> free/libre/open (FLO)
For Sugar Labs web project, perhaps link to the repository.
| Sugar Labs builds open-source tools that make learning playful and accessible. I recently contributed dark mode to a Sugar Labs web project. This post outlines the problem I encountered, how I debugged and fixed it, and the key lessons I learned so others can ship accessible theming with confidence. | ||
|
|
||
| ## The Problem | ||
| The Sugar Labs website originally lacked a Dark Mode option, which made browsing less comfortable in low-light conditions. This was particularly noticeable for developers and users who preferred darker themes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were there other requests for Dark Mode other than yours? If so, please reference.
If there are any articles that document the benefits of Dark Mode, please reference.
| ## The Problem | ||
| The Sugar Labs website originally lacked a Dark Mode option, which made browsing less comfortable in low-light conditions. This was particularly noticeable for developers and users who preferred darker themes. | ||
|
|
||
| Without dark mode, the bright interface could cause eye strain and reduce accessibility for users with light sensitivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be consistent with capitalization. "Dark Mode" or "dark mode". Don't switch between the two.
| The Sugar Labs website originally lacked a Dark Mode option, which made browsing less comfortable in low-light conditions. This was particularly noticeable for developers and users who preferred darker themes. | ||
|
|
||
| Without dark mode, the bright interface could cause eye strain and reduce accessibility for users with light sensitivity. | ||
| - **Goal:** Deliver a robust dark mode that respects system preference, includes a manual toggle with persistence, and maintains accessible contrast across the interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe reference how it "respects system preference". That's interesting.
|
Thanks for the review! I’ll start fresh on a clean branch and make sure all comments are addressed before submitting the new PR. |
Added a new blog post detailing the process of implementing Dark Mode for the Sugar Labs website.
The post covers the motivation, challenges faced during development, debugging steps, and the final solution providing valuable insights for contributors who want to work on theming and accessibility features.
fixes: #440