Skip to content

Conversation

@Niranjan7407
Copy link
Contributor

@Niranjan7407 Niranjan7407 commented Mar 12, 2025


Name: Try Now Not Visible
about: Fixed Try Now Button Visibility in Mobiles

Description

I have made the Menu Bar div a bit small so that the Try Now button has space to be visible for the user.

Mobile browsers varies in having the tab menu below the browser. The issue was that the Try Now button was not visible for browsers with the tab menu at the bottom of the screen. i fixed it by moving the button a bit upwards, so that the button is visible for every mobile user, irrespective of the browser they use.

Related Issue

This PR fixes #30

Changes Made

  • Made the Menu Bar div from flex-grow:1 to flex-grow:0.7

Testing Performed

  • Tested the website on browsers, both with and without tab menu at the bottom.

Additional Notes for Reviewers

Please provide any suggestions or feedback regarding the submission made. Thank You!

Results

  • Browser with Tab Menu

WhatsApp Image 2025-03-12 at 13 11 08_f86d84cc
-Browser without Tab Menu

WhatsApp Image 2025-03-12 at 13 11 08_4fdce7aa

@sa-fw-an
Copy link
Member

For now this method fixes the "Visibility" issue in mobile. But this is a temporary solution as it does not look good when scrolled upon, and this is not how things go about. Please Find a proper way/solution to fix it. Then ill merge this PR :)

@Niranjan7407
Copy link
Contributor Author

WhatsApp Image 2025-03-12 at 15 14 14_84232b36

WhatsApp Image 2025-03-12 at 15 14 14_00ffa9ef

This is how it looks now.

I can make it have rounded corners if you'd like to have it.

@sa-fw-an
Copy link
Member

No it shld completely touch the bottom. The menu bar shld be complete from top to bottom and the Try Now button must be at bottom in all VIEWS. This is inconsistant.

@Niranjan7407
Copy link
Contributor Author

Niranjan7407 commented Mar 12, 2025

@sa-fw-an Honestly, I think it is a design flaw. Cause how can we know if the browser has a tab bar or not, or even if it has one, it disappears as you scroll down a bit in a few web browsers, and it remains in a few. How are we supposed to know if its there or not?

@Niranjan7407
Copy link
Contributor Author

Issue fixed by @sa-fw-an in the commit 29c40c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try More Not Visible

2 participants