Skip to content

Conversation

@mayur-driod
Copy link
Contributor


name: Added Testimonial Data
about: Based on issue #16 . According to the issue "We don't have any quotes from ordinary users".

Description

Based on issue #16 . According to the issue "We don't have any quotes from ordinary users". So I added data from the sugarlabs testimonial here. I have also included the testimonials recommended by @pikurasa.

Related Issue

This PR fixes #16

Changes Made

  • Change 1: in src\constants\Testimonials.ts deleting the dummy data.
  • Change 2 in src\constants\Testimonials.ts adding more actual data from the sources mentioned above.
  • ...

Testing Performed

  • I have run the server and confirmed it works as expected.
  • Connected to the server on multiple devices to see that it is responsive.
    Screenshot 2025-03-12 140836
    ...

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes for Reviewers

Hello I hope this Finds you well. I am a first time contributor to Sugar Labs and due to my unfamiliarity I have not made the necessary changes to the documentations or the tests that show my changes are effective. I would really appreciate it if you can guide me forward. Thank you.


Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@sa-fw-an
Copy link
Member

This PR is ok. Please Lint the files and also remove the package.json and its lock file as well. There is no need of pushing these files.
To Lint individual file on windows please refer the thread in this PR:

@mayur-driod
Copy link
Contributor Author

@sa-fw-an I did as you mentioned but the package.json and its lock files are not allowing the run to build

@sa-fw-an
Copy link
Member

Please raise a new PR that has only the Constants file of testimonials changed.

@sa-fw-an sa-fw-an closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add user quotes to MB landing page

2 participants