Skip to content

Conversation

@Harshalvk
Copy link
Contributor


name: feat: add code-block for markdown
about: Submit changes to the project for review and inclusion

Description

Add markdown code-block support
fixes issue #19

Related Issue

#19

This PR fixes #

Changes Made

Add code-block support
image

  • Change 1
  • Change 2
  • ...

Testing Performed

  • Tested feature X in scenario Y.
  • Ran unit tests for component Z.
  • Tested on browsers A, B, and C.
  • ...

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes for Reviewers


Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@sa-fw-an
Copy link
Member

Ive tried you PR and there are some things I did notice:

  • The Code block works, but it fails in multiline code. It is not able to reproduce the exact code with news lines and all that, Please Fix that
  • The Copy function does not work
  • Most of the features have been removed like the quote blocks and other few functionalities.
  • Please check if the code builds before commititng (Check npm run build runs successfully)
  • Always Lint the code before commiting, which ever file you edit please Lint it using npm run format:file <filename>. For reference please visit this PR, there is a complete explaination on how to lint individual files. windows OS added #12

@Harshalvk
Copy link
Contributor Author

Okay, I will fix my code implementation and ensure it meets all the criteria you mentioned here: #31 (comment).

@sa-fw-an
Copy link
Member

@sa-fw-an sa-fw-an closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants