Skip to content

DMP '25 Week04 Update by Harshit Verma #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2025
Merged

DMP '25 Week04 Update by Harshit Verma #254

merged 4 commits into from
Jul 15, 2025

Conversation

@therealharshit
Copy link
Member

@therealharshit therealharshit commented Jun 29, 2025

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes for Reviewers

@pikurasa published week 04 blog

@github-actions
Copy link

github-actions bot commented Jun 29, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@github-actions
Copy link

github-actions bot commented Jun 29, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

pikurasa
pikurasa requested changes Jul 1, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@therealharshit therealharshit requested a review from pikurasa July 1, 2025 18:00
pikurasa
pikurasa requested changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@pikurasa pikurasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images and video are super-helpful and awesome.

Please address some of the grammar and style feedback.

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@therealharshit
Fix grammar and terminology
04bdd5a 
- Corrected plural form from "childrens" to "children".
- Spelled out "VTE" as "Virtual Terminal Emulator".
- Capitalization of "LLM".
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@therealharshit
Copy link
Member Author

therealharshit commented Jul 8, 2025

The images and video are super-helpful and awesome.

Please address some of the grammar and style feedback.

Resolved in 04bdd5a.

Thanks for the feedback.

@therealharshit therealharshit requested a review from pikurasa July 9, 2025 20:58
@pikurasa pikurasa merged commit eff0629 into sugarlabs:main Jul 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pikurasa pikurasa Awaiting requested review from pikurasa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@therealharshit @pikurasa