Skip to content

Week 2 blog by Aman Naik #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

Week 2 blog by Aman Naik #228

merged 2 commits into from
Jun 23, 2025

Conversation

@amannaik247
Copy link
Member

@amannaik247 amannaik247 commented Jun 17, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@amannaik247 amannaik247 marked this pull request as draft June 17, 2025 17:33
@github-actions
Copy link

github-actions bot commented Jun 17, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@amannaik247 amannaik247 marked this pull request as ready for review June 17, 2025 18:21
@github-actions
Copy link

github-actions bot commented Jun 17, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@pikurasa
Copy link
Contributor

pikurasa commented Jun 18, 2025

@sa-fw-an

Do you know why I'm getting the following error in the console (when running npm run dev on this branch)?:

Files in the public directory are served at the root path.
Instead of /public/assets/Images/aman_naik_week2_img1.png, use /assets/Images/aman_naik_week2_img1.png.
Files in the public directory are served at the root path.
Instead of /public/assets/Images/aman_naik_week2_img2.png, use /assets/Images/aman_naik_week2_img2.png.

@amannaik247
Copy link
Member Author

amannaik247 commented Jun 18, 2025 •
edited
Loading

@sa-fw-an

Do you know why I'm getting the following error in the console (when running npm run dev on this branch)?:

Files in the public directory are served at the root path.
Instead of /public/assets/Images/aman_naik_week2_img1.png, use /assets/Images/aman_naik_week2_img1.png.
Files in the public directory are served at the root path.
Instead of /public/assets/Images/aman_naik_week2_img2.png, use /assets/Images/aman_naik_week2_img2.png.

I think since this website is based on NextJS so the public directory is like a special directory.
Any file you put inside the public folder can be accessed directly from the root URL of your site.

Because the public folder is already mapped to the root / of your website.
So writing /public/... is like saying /root/public/..., which doesn’t exist to the browser.

Will follow the convention and remove the public/ and push again.

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@pikurasa
Copy link
Contributor

pikurasa commented Jun 18, 2025

Will follow the convention and remove the public/ and push again.

I think that fixed it. However, I do see one thing that I'll point out in a review.

pikurasa
pikurasa requested changes Jun 18, 2025
View reviewed changes
@sa-fw-an
Copy link
Member

sa-fw-an commented Jun 18, 2025

@sa-fw-an

Do you know why I'm getting the following error in the console (when running npm run dev on this branch)?:

Files in the public directory are served at the root path.
Instead of /public/assets/Images/aman_naik_week2_img1.png, use /assets/Images/aman_naik_week2_img1.png.
Files in the public directory are served at the root path.
Instead of /public/assets/Images/aman_naik_week2_img2.png, use /assets/Images/aman_naik_week2_img2.png.

I dont see any issues. Seems it is fixed

@sa-fw-an
Copy link
Member

sa-fw-an commented Jun 18, 2025

I think since this website is based on NextJS so the public directory is like a special directory.

Well our website is not based on NextJS. It is a react app with vite as a bundler.

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@amannaik247
Copy link
Member Author

amannaik247 commented Jun 19, 2025

@pikurasa please review

@github-actions
Copy link

github-actions bot commented Jun 22, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@pikurasa pikurasa merged commit 3ebc94d into sugarlabs:main Jun 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pikurasa pikurasa pikurasa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amannaik247 @pikurasa @sa-fw-an