Skip to content

Conversation

@haroon10725
Copy link
Contributor

@pikurasa Can you please review it.

@github-actions
Copy link

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

Comment on lines +7 to +8
author: "Muhammad Haroon"
description: "SSoC'25 Contributor working on Generative AI Instrument Sample Generation for Music Blocks"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the new format for this. You can remove the description, it will pull automatically from the authors page, and for author use the new convention. See docs to find the new convention

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sa-fw-an I think we can merge the PR with these format issues and once author page gets merged will create a separate PR for it, fixing all the format issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y raise seperate PR's, Its just a simple fix. Its better if we push it before merging. Please change and push the code

Comment on lines +66 to +72
## Connect with Me

- GitHub: [@haroon10725](https://github.com/haroon10725)
- Gmail: [[email protected]](mailto:[email protected])
- LinkedIn: [Muhammad Haroon](https://www.linkedin.com/in/muhammad-haroon-7003b923b/)

--- No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required as we already have an authors page for that. The data will be redundant. Please remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sa-fw-an I think we can merge the PR with these format issues and once #209 gets merged will create a separate PR for it, fixing all the format issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better if u push before merging, otherwise there will be an extra commit and a waste of PR, when we already know that this is not needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haroon10725 I merged it. Please remove the redundant info when you have the chance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pikurasa Thankyou, will create a PR soon removing redundant info.

@pikurasa pikurasa merged commit c1444c7 into sugarlabs:main Jun 16, 2025
3 checks passed
saumyashahi pushed a commit to saumyashahi/www-v2 that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants