-
Notifications
You must be signed in to change notification settings - Fork 120
SSoC' 25 blog post for week 02 by Muhammad Haroon #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
| author: "Muhammad Haroon" | ||
| description: "SSoC'25 Contributor working on Generative AI Instrument Sample Generation for Music Blocks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the new format for this. You can remove the description, it will pull automatically from the authors page, and for author use the new convention. See docs to find the new convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sa-fw-an I think we can merge the PR with these format issues and once author page gets merged will create a separate PR for it, fixing all the format issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y raise seperate PR's, Its just a simple fix. Its better if we push it before merging. Please change and push the code
| ## Connect with Me | ||
|
|
||
| - GitHub: [@haroon10725](https://github.com/haroon10725) | ||
| - Gmail: [[email protected]](mailto:[email protected]) | ||
| - LinkedIn: [Muhammad Haroon](https://www.linkedin.com/in/muhammad-haroon-7003b923b/) | ||
|
|
||
| --- No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required as we already have an authors page for that. The data will be redundant. Please remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its better if u push before merging, otherwise there will be an extra commit and a waste of PR, when we already know that this is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haroon10725 I merged it. Please remove the redundant info when you have the chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pikurasa Thankyou, will create a PR soon removing redundant info.
@pikurasa Can you please review it.