Skip to content

Conversation

@rakesh0x
Copy link

@rakesh0x rakesh0x commented Jun 14, 2025

Pull Request

-- Description
This PR enhances the user experience on the News section of our new website by providing clear feedback during the share action. Previously, although the share functionality worked correctly, users received no indication that the link had been copied.

To address this, I integrated a Toaster notification using shadcn/ui. Now, when a user attempts to share the latest news, a toast message saying "URL copied successfully" appears at the bottom-right corner of the screen. The functionality is wrapped in a try-catch block to handle any unexpected errors gracefully without making any network requests.

-- Implementation Details
Added shadcn Toaster component

Included necessary dependencies

Implemented notification logic in the share handler

-- Testing
Manually tested in the local development environment

Verified that the toast message triggers correctly on successful copy

Confirmed graceful error handling in edge cases

@github-actions
Copy link

❌ Checks Failed

Status: 🚫 Not ready to merge

Please fix the following issues before merging:

📝 Code Linting Failed

Issue: Code formatting or style violations detected.

Specific problems:

• Code formatting issues detected

How to fix:

Platform Command Description
🐧 Unix/macOS/Linux npm run format Auto-fix all formatting issues
🪟 Windows npm run format:file <filename> Fix specific files
🔍 Check Only npm run format:check Check formatting without fixing

Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions.


🛠️ Next Steps

  1. Fix the issues mentioned above
  2. Test locally to ensure everything works
  3. Push your fixes to this branch
  4. Wait for re-check - This bot will automatically run again

🤖 This comment will be updated automatically when you push new commits

@github-actions
Copy link

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@rakesh0x rakesh0x changed the title Added Toaster when sharing News add toast notification for share link action Jun 14, 2025
@rakesh0x rakesh0x changed the title add toast notification for share link action added toast notification for share link action Jun 14, 2025
@sa-fw-an sa-fw-an closed this Jun 16, 2025
@sa-fw-an
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants