DMP 25 week 01 blog by Aman Naik #192
Conversation
|
@pikurasa created this PR right now. I accidentally created the PR in my own repo early morning. |
|
@amannaik247 Please ensure that you test it locally to confirm the visual appearance. |
@sa-fw-an checked! |
|
@pikurasa please proof read this, for merging. |
pikurasa
left a comment
pikurasa
left a comment
There was a problem hiding this comment.
When I tested your branch, the MD did not render.
I noticed that the file is missing ".md", so I tried changing 2025-06-09-dmp-25-AmanNaik-week01 to 2025-06-09-dmp-25-AmanNaik-week01.md and it worked.
Please run npm run dev before raising a PR, so you know what the results of your code would be.
Please make requested changes, test them and review them, then commit, push, and request a new review.
src/constants/MarkdownFiles/posts/2025-06-09-dmp-25-AmanNaik-week01
Outdated
Show resolved
Hide resolved
src/constants/MarkdownFiles/posts/2025-06-09-dmp-25-AmanNaik-week01
Outdated
Show resolved
Hide resolved
amannaik247
force-pushed
the
patch-2
branch
2 times, most recently
from
e8599ad to
862d331
Compare
|
@amannaik247 Please Add an Authors file and change the titles of the blog. For documentation refer this Change this PR and also for week 2 follow the new convention Have a look at my blog for new authors page and make a page somewhat like this |
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
|
@sa-fw-an please review. |
pikurasa
left a comment
pikurasa
left a comment
There was a problem hiding this comment.
Please check out the one comment about new line.
| # Week 1 Progress Report by Aman Naik | ||
|
|
||
| **Project:** [Add an AI-assistant to the Write Activity](https://github.com/sugarlabs/write-activity/issues/52) | ||
| **Mentors:** [Walter Bender](https://github.com/walterbender), [Ibiam Chihurumnaya](https://github.com/chimosky) |
There was a problem hiding this comment.
There seems to be something happening here:
Perhaps try adding a space to see if that forces the new line?
There was a problem hiding this comment.
In the latest commit I have already added spaces before the line of "Reporting Period".
According to the screen shot there is a period(.) after Chihurumnaya, but in this commit I have removed that period. This indicates that perhaps you are not running the latest commit's code.
Please check once again. Here is the screenshot of the website when I ran it.
There was a problem hiding this comment.
The requested change already exists in the last commit.
Perhaps pull again from this branch?
Because I can see "Reporting period" on a new line using this code.
4 participants
Week 01 blog for DMP 25.