Skip to content

Conversation

@imshrishk
Copy link

Description

This PR makes small changes to optimize the image loading better.

@FirePheonix
Copy link
Contributor

we are going to be adding many more images.
The cache the website is currently taking is a lot. Optimization improvements are going to take place till the end..

This is good, but i think it's too early for this PR. @sa-fw-an what do you say?

@imshrishk
Copy link
Author

Personally, I think it makes sense to have initial stages of projects to have a little bit of optimization. People making future commits have a standard set for them and they push codes with small optimizations like this one without leaving it for someone else to do

@sa-fw-an
Copy link
Member

@imshrishk I went through u your PR. In some places the Images were not responsive, also I noticed few images did not render until hovered upon, please fix them. This PR is good and seems to reduce memory the site was taking previously. Sounds resonable to optimize the pages as we progress. Good work :)

@FirePheonix
Copy link
Contributor

Personally, I think it makes sense to have initial stages of projects to have a little bit of optimization. People making future commits have a standard set for them and they push codes with small optimizations like this one without leaving it for someone else to do

sound good to me. go ahead..

@imshrishk
Copy link
Author

@sa-fw-an please check if the issue is fixed yet. It worked on my local but as a precaution I changed it.

@sa-fw-an
Copy link
Member

sa-fw-an commented Mar 7, 2025

Please fix merge conflicts and raise a new PR.

@sa-fw-an sa-fw-an closed this Mar 7, 2025
@imshrishk
Copy link
Author

Will do tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants