Skip to content

fix Widget block gets disable after Restore #4670 #4807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Widget block gets disable after Restore #4670 #4807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion js/piemenus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@

// Ensure synth is initialized before proceeding
if (!that.activity.logo.synth) {
console.debug('Creating synth in logo');

Check warning on line 392 in js/piemenus.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint 

Strings must use doublequote
that.activity.logo.synth = new Synth();
}

Expand Down Expand Up @@ -501,7 +501,7 @@
that.activity.logo.synth.createDefaultSynth(0);
await that.activity.logo.synth.loadSynth(0, DEFAULTVOICE);
} catch (e) {
console.debug('Error initializing synth:', e);

Check warning on line 504 in js/piemenus.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint 

Strings must use doublequote
return;
}
}
Expand All @@ -516,7 +516,7 @@
that.activity.logo.synth.setMasterVolume(PREVIEWVOLUME);
that.activity.logo.synth.setVolume(0, DEFAULTVOICE, PREVIEWVOLUME);
} catch (e) {
console.debug('Error setting volume:', e);

Check warning on line 519 in js/piemenus.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint 

Strings must use doublequote
return;
}

Expand All @@ -526,7 +526,7 @@
try {
await that.activity.logo.synth.trigger(0, [obj[0] + obj[1]], 1/8, DEFAULTVOICE, null, null, false);
} catch (e) {
console.debug('Error triggering note:', e);

Check warning on line 529 in js/piemenus.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint 

Strings must use doublequote
} finally {
// Ensure trigger lock is released after a delay
setTimeout(() => {
Expand All @@ -535,7 +535,7 @@
}
}
} catch (e) {
console.error('Error in pitch preview:', e);

Check warning on line 538 in js/piemenus.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint 

Strings must use doublequote
}
};

Expand Down Expand Up @@ -668,9 +668,9 @@
const setupAudioContext = async () => {
try {
await Tone.start();
console.debug('Audio context started');

Check warning on line 671 in js/piemenus.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint 

Strings must use doublequote
} catch (e) {
console.debug('Error starting audio context:', e);

Check warning on line 673 in js/piemenus.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint 

Strings must use doublequote
}
};

Expand Down Expand Up @@ -3499,7 +3499,6 @@

wheel.navItems[2].navigateFunction = () => {
that.blocks.activeBlock = blockBlock;
that.blocks.extract();
that.blocks.sendStackToTrash(that.blocks.blockList[blockBlock]);
docById("contextWheelDiv").style.display = "none";
// prompting a notification on deleting any block
Expand Down