Fix redundant behavior in SensorsBlocks and clean RGB block handling #4798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
zealot-zew
reviewed
Nov 9, 2025
zealot-zew
left a comment
zealot-zew
left a comment
There was a problem hiding this comment.
looks like you have chat gpt the entire code file, thats why youre failing testcases
Member
|
This PR has lots of unrelated changes, making it difficult to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the SensorsBlocks module where duplicate methods in RGB blocks and input handling were causing redundant behavior.
Changes made:
All local tests pass successfully. These changes should make the pitch, loudness, and sensor blocks behave consistently and reduce unexpected duplicates or errors.