Skip to content

Recreated LEGO Bricks Widget README. #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2025
Merged

Recreated LEGO Bricks Widget README. #4792

merged 3 commits into from
Nov 4, 2025

Conversation

@roshninaktode
Copy link
Contributor

@roshninaktode roshninaktode commented Nov 3, 2025

This PR moves the LEGO Bricks Widget section from guide/README.md to a new file named lego-block-widget-README.md in the root directory, as requested in issue .
fixes issue #4789

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

✅ All Jest tests passed! This PR is ready to merge.

omsuneri
omsuneri requested changes Nov 4, 2025
View reviewed changes
Copy link
Member

@omsuneri omsuneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roshninaktode please dont alter the guide instead i m asking to change this readme https://github.com/sugarlabs/musicblocks/edit/master/README.md
please undo you changes in the guide/readme

omsuneri
omsuneri reviewed Nov 4, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

✅ All Jest tests passed! This PR is ready to merge.

@roshninaktode
Copy link
Contributor Author

roshninaktode commented Nov 4, 2025

Hi @omsuneri, I’ve made the requested changes — restored guide/README.md, removed the LEGO Bricks Widget section from the main README.md, and added it to lego-block-widget-README.md.
Please review , and do let me know if any changes are required.

@omsuneri
Copy link
Member

omsuneri commented Nov 4, 2025

@roshninaktode nice just delete the changes you made in the guide/readme.md they are not really needed else it lgtm !!

@roshninaktode
Copy link
Contributor Author

roshninaktode commented Nov 4, 2025

Hi @omsuneri,
I’ve restored the LEGO Bricks Widget section in guide/README.md as requested.
Please review when you get a chance 😊

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

✅ All Jest tests passed! This PR is ready to merge.

@omsuneri omsuneri self-requested a review November 4, 2025 09:01
omsuneri
omsuneri approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@omsuneri omsuneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omsuneri omsuneri merged commit 590132e into sugarlabs:master Nov 4, 2025
5 checks passed
@omsuneri omsuneri mentioned this pull request Nov 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omsuneri omsuneri omsuneri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roshninaktode @omsuneri