Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}
},
"extends": ["eslint:recommended", "prettier"],
"ignorePatterns": ["lib/**"],
"ignorePatterns": ["lib/jquery*.js", "lib/jquery*.min.js", "planet/libs/**", "**/*.min.js"],
"rules": {
"no-console": "off",
"no-mixed-spaces-and-tabs": "warn",
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Get changed JavaScript files
id: get_files
run: |
CHANGED_FILES=$(git diff --name-only ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} -- '*.js')
CHANGED_FILES=$(git diff --name-only ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} -- '*.js' | xargs -I {} sh -c 'test -f "{}" && echo "{}"' || true)
echo "files<<EOF" >> $GITHUB_ENV
echo "$CHANGED_FILES" >> $GITHUB_ENV
echo "EOF" >> $GITHUB_ENV
Expand All @@ -38,4 +38,8 @@ jobs:
run: |
echo "Linting the following files:"
echo "$files"
echo "$files" | xargs npx eslint
if [ -n "$files" ]; then
echo "$files" | xargs npx eslint
else
echo "No existing JavaScript files to lint."
fi
3 changes: 1 addition & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@

<script src="lib/reqwest.js" defer></script>

<!-- <script src="lib/jquery-3.7.1.js"></script> -->
<script src="lib/jquery-2.1.4.min.js"></script>
<script src="lib/jquery-3.7.1.min.js"></script>
<script src="lib/jquery-ui.js" defer></script>
<script src="lib/materialize.min.js" defer></script>
<script src="lib/webL10n.js" defer></script>
Expand Down
570 changes: 0 additions & 570 deletions lib/jquery-2.1.4.js

This file was deleted.

4 changes: 0 additions & 4 deletions lib/jquery-2.1.4.min.js

This file was deleted.

4 changes: 0 additions & 4 deletions lib/jquery-3.2.1.min.js

This file was deleted.

4 changes: 2 additions & 2 deletions lib/sw.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
var CACHE_NAME = 'music-blocks-site-precache';

Check warning on line 1 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
var urlsToCache = [
'index.html',

Check warning on line 3 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
'loading-animation.mp4',

Check warning on line 4 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
'loading-animation.webm',

Check warning on line 5 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
'manifest.json',

Check warning on line 6 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
'favicon.ico',

Check warning on line 7 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote

'header-icons/a-button.svg',

Check warning on line 9 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
'header-icons/add.svg',

Check warning on line 10 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
'header-icons/advanced-button.svg',

Check warning on line 11 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
'header-icons/apply.svg',

Check warning on line 12 in lib/sw.js

View workflow job for this annotation

GitHub Actions / Lint updated JavaScript files with ESLint

Strings must use doublequote
'header-icons/b-button.svg',
'header-icons/beginner-button.svg',
'header-icons/bigger-button.svg',
Expand Down Expand Up @@ -312,9 +312,9 @@
'planet/js/GlobalTag.js',
'planet/js/main.js',
'planet/js/Publisher.js',
'planet/lib/jquery-3.2.1.min.js',
'planet/libs/jquery-3.7.1.min.js',

'lib/jquery-3.2.1.js',
'lib/jquery-3.7.1.min.js',

'sounds/samples/manifest.js'
];
Expand Down
2 changes: 1 addition & 1 deletion planet/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0"/>

<!--Import jQuery before materialize.js-->
<script type="text/javascript" src="libs/jquery-3.2.1.min.js"></script>
<script type="text/javascript" src="libs/jquery-3.7.1.min.js"></script>
<script type="text/javascript" src="libs/materialize.min.js"></script>
<script type="text/javascript" src="libs/localforage.min.js"></script>

Expand Down
4 changes: 0 additions & 4 deletions planet/libs/jquery-3.2.1.min.js

This file was deleted.

2 changes: 2 additions & 0 deletions planet/libs/jquery-3.7.1.min.js

Large diffs are not rendered by default.