-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add complete Hindi,Chinese(Simplified) and Japanese (Kana & Kanji) translations #4762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
I'm doing a spot check right now. I've run across something problematic that seems to be pervasive in these new translations (at least for kana) Example: Pitch staircase
The test of this branch is on the left; the https://musicblocks.sugarlabs.org/ version is on the right (I cannot get https://sugarlabs.github.io/musicblocks/ to run, for some reason). The left is a phonetic spelling out, in katakana, of what we already have. It would be kind of like me saying that "Watashi no namae wa Devin desu" is an English translation of the Japanese 私の名前はデヴィンです。It's not a translation; an English speaker wouldn't understand it. It's just a phonetic version of the Japanese, written in the Roman alphabet. |
|
This is another category of regression:
The translation we have in https://musicblocks.sugarlabs.org/ is better than this branch. I don't recommend overwriting any of the human-made translations that we currently have. |
|
@pikurasa In my prompt, I specifically enforced that only Japanese kana should be used. Because of this, the output ended up being phonetic spellings in katakana rather than proper translations. Not every Japanese word can be represented accurately in kana, so the meaning wasn’t fully conveyed. I will change the prompt. I only realized this when you pointed out the flaw. |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
…n value in localstorage
|
✅ All Jest tests passed! This PR is ready to merge. |
|
It is still giving phonetic spellings. This, for example, is the same for Set Drum: |
|
@pikurasa but i haven't changed the JA file yet |
It still displays the same as before, and your particular change seems unrelated to fixing this particular issue.
|
|
✅ All Jest tests passed! This PR is ready to merge. |






This PR adds full localization support for: