Skip to content

Conversation

@ac-mmi
Copy link
Contributor

@ac-mmi ac-mmi commented Sep 16, 2025

This PR adds full localization support for:

  • Hindi (hi) – complete translations for all strings.
  • Chinese (zh-CN) – complete translations for all strings.
  • Japanese (ja) – complete translations in both Kana and Kanji for better readability and coverage.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@ac-mmi ac-mmi changed the title Add complete Hindi and Japanese (Kana & Kanji) translations Add complete Hindi,Chinese(Simplified) and Japanese (Kana & Kanji) translations Sep 17, 2025
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@pikurasa
Copy link
Collaborator

I'm doing a spot check right now.

I've run across something problematic that seems to be pervasive in these new translations (at least for kana)

Example: Pitch staircase

Screenshot from 2025-09-18 11-47-40

The test of this branch is on the left; the https://musicblocks.sugarlabs.org/ version is on the right (I cannot get https://sugarlabs.github.io/musicblocks/ to run, for some reason).

The left is a phonetic spelling out, in katakana, of what we already have. It would be kind of like me saying that "Watashi no namae wa Devin desu" is an English translation of the Japanese 私の名前はデヴィンです。It's not a translation; an English speaker wouldn't understand it. It's just a phonetic version of the Japanese, written in the Roman alphabet.

@pikurasa
Copy link
Collaborator

This is a regression:

Screenshot from 2025-09-18 12-10-36

In the dropdown list, it's suppose to be にほんご (in kana); but, instead, it says something that looks like maybe the word Japanese in Chinese.

@pikurasa
Copy link
Collaborator

This is another category of regression:

Screenshot from 2025-09-18 12-28-24

The translation we have in https://musicblocks.sugarlabs.org/ is better than this branch.

I don't recommend overwriting any of the human-made translations that we currently have.

@ac-mmi
Copy link
Contributor Author

ac-mmi commented Sep 18, 2025

@pikurasa In my prompt, I specifically enforced that only Japanese kana should be used. Because of this, the output ended up being phonetic spellings in katakana rather than proper translations. Not every Japanese word can be represented accurately in kana, so the meaning wasn’t fully conveyed. I will change the prompt. I only realized this when you pointed out the flaw.

@ac-mmi
Copy link
Contributor Author

ac-mmi commented Sep 18, 2025

This is a regression:

Screenshot from 2025-09-18 12-10-36 In the dropdown list, it's suppose to be にほんご (in kana); but, instead, it says something that looks like maybe the word Japanese in Chinese.

I don’t know how you were able to run this, because it takes the localStorage language preference as the filename and then calls the file. Right now it showed zhcn instead of zh_cn, which is the filename in my locales folder. I corrected it, so you can check now.

@github-actions
Copy link
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

languagebox.test.js

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@pikurasa
Copy link
Collaborator

It is still giving phonetic spellings.

This, for example, is the same for Set Drum:
ザ ピッチ ステアケース ツール トゥ イズ ユーズド トゥ ジェネレート ピッチズ フロム ア ギブン レイシオ

@pikurasa
Copy link
Collaborator

Screenshot from 2025-09-19 15-18-16

@ac-mmi
Copy link
Contributor Author

ac-mmi commented Sep 20, 2025

@pikurasa but i haven't changed the JA file yet

@pikurasa
Copy link
Collaborator

@pikurasa In my prompt, I specifically enforced that only Japanese kana should be used. Because of this, the output ended up being phonetic spellings in katakana rather than proper translations. Not every Japanese word can be represented accurately in kana, so the meaning wasn’t fully conveyed. I will change the prompt. I only realized this when you pointed out the flaw.

It still displays the same as before, and your particular change seems unrelated to fixing this particular issue.

Screenshot from 2025-09-23 15-49-17

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@ac-mmi ac-mmi closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants