Skip to content

Conversation

@Anshumancanrock
Copy link
Contributor

@Anshumancanrock Anshumancanrock commented Sep 15, 2025

What does this PR do?

This PR removes all remaining references to the deprecated sugar-web library from the Music Blocks codebase. It deletes the outdated lib/sugar-web/ directory, cleans up related entries in the service worker, and removes obsolete comments. The change fully eliminates sugar-web while preserving application functionality and ensuring no breaking changes.

Fixes #4680

After Fix (Video):

Recording.2025-09-18.002441.mp4

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@Anshumancanrock
Copy link
Contributor Author

@omsuneri Hi Sir, Kindly review my PR and let me know if you want any changes. Thank you!

@Anshumancanrock Anshumancanrock mentioned this pull request Sep 17, 2025
5 tasks
@omsuneri
Copy link
Member

@omsuneri Hi Sir, Kindly review my PR and let me know if you want any changes. Thank you!

I ll test this and will let you know !!

@omsuneri
Copy link
Member

@Anshumancanrock please change your commit message to follow our contributors guideline
"done" and "fix" seems very unprofessional commit messages cause over the time we only have commit messages with us to track the code !!
check this out https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@Anshumancanrock
Copy link
Contributor Author

@omsuneri Thanks for the suggestion ! have fixed the commit message and i will take care of this from now onwards.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove sugar-web library

2 participants