-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: AI sample generation in Music Blocks #4740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender Can you please review it. |
|
Hmm. When an error occurs (e.g., cross-origin error) it still tries to generate (or at least the Generating message keeps flashing.) |
|
I get cross-origin errors when running from a local server. Any suggestions? |
|
@walterbender Try running index.html directly from the folder. |
|
I tried that first. I got cross-origin errors that way too. |
Can you please share the error? |
|
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://localhost:8000/generate?prompt=. (Reason: CORS request did not succeed). Status code: (null). |
Is FastAPI server running successfully? Were you able to set the backend repo locally? At the moment backend is not hosted on AWS. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@haroon10725 has this PR been deprecated (it still has the trimmer)? |
I commented out the trimmer code but didn’t remove it. In the meeting, you mentioned that we should remove it because we don’t need it in Music Blocks and can use another audio trimmer online. However, @pikurasa suggested not removing it until we are sure that the AI Sample Generation Tool can generate samples that can be used directly in Music Blocks without needing trimming. Context: When the sample duration was reduced from 10 seconds to 2 seconds, you suggested removing the trimmer functionality. |
No description provided.