-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Migrate to i18next for internationalization #4731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…locks into internalization-js
….js so that renderLanguageSelectIcon() works correctly
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Very close to finishing this. Please do add instructions for running the Python script in po/README.md @pikurasa this is a major update to i18n. Can you please test Kanji and Kana to make sure they are behaving properly? Thx. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@pikurasa It would be helpful if you could test Kanji and Kana before we merge this. |
|
When I tried to just fetch the code and run it locally without a server, it wouldn't open for me. I tried in incognito as well, but no luck. Here are the captured logs: I then tried a local server, and it worked. Instructions: https://github.com/sugarlabs/musicblocks/?tab=readme-ov-file#how-to-set-up-a-local-server Maybe this is expected, but "FYI". I'm continuing to test now. |
|
I don't think that the current i18n works w/o running a server either.
…On Sun, Sep 7, 2025 at 7:40 AM Devin Ulibarri ***@***.***> wrote:
*pikurasa* left a comment (sugarlabs/musicblocks#4731)
<#4731 (comment)>
When I tried to just fetch the code and run it locally without a server,
it wouldn't open for me. I tried in incognito as well, but no luck.
Here are the captured logs:
-1757244818200.log
<https://github.com/user-attachments/files/22196407/-1757244818200.log>
I then tried a local server, and it worked. Instructions:
https://github.com/sugarlabs/musicblocks/?tab=readme-ov-file#how-to-set-up-a-local-server
Maybe this is expected, but "FYI".
I'm continuing to test now.
—
Reply to this email directly, view it on GitHub
<#4731 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6PXYND5CPXEWRLJ2CG7UL3RQKQRAVCNFSM6AAAAACCJ3JTYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENRTG4YTEOBVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Walter Bender
Sugar Labs
https://www.sugarlabs.org
<http://www.sugarlabs.org>
|
I mean that it wouldn't open the first time. On the other branches, you can open it the first time (but, yes, after that you cannot truly test i18n). At any rate, I have some results. I'll share them in the next comment. |
|
On this branch, I am able to run in Japanese (Kanji). I found only two palette strings that are untranslated: media and sensors; and one block string: duration (MS) There are some missing strings in other places (e.g.) help, but I expect those. "Media" and "Sensors", I'm pretty sure have been translated. As for Japanese (Kana), I cannot find a path to getting it to work. I tried:
None of these things seem to get a user into (Kana). You can see the testing in this video, if that helps: https://youtu.be/x7RdFk_QppQ |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@pikurasa I’ve resolved the language change issue for kana/kanji. Tested on my side, and it’s working now. |
|
Looks good to me. @pikurasa ? |
|
This updated version does switch to kana. Some observations:
|
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Is this ready for testing again? Also, please be mindful that there are conflicts that need to be resolved before merging. |
|
@pikurasa yes i solved that loading issue in japanese language and that advance mode issue as well |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
It works. While testing, it sometimes seemed to need a refresh to go into advanced mode. This would be a regression, but it was inconsistent in its reproducibility. Also, once I ran into this:
I've never seen that before. But, again, that was inconsistent in its reproducibility. @walterbender was also going to review once again and look into whether this PR is still using the new method of switching between kana and kanji. |
|
@pikurasa This issue actually occurred earlier. The root cause was in |

@walterbender Switch Musicblocks to use i18next for language management