Implemented tuner and manual cent adjustment in sampler widget #4725

AnvitaPrasad · 2025-07-16T20:46:35Z

Added tuner functionality and manual cent adjustment feature to the sampler widget.
Code cleanup and refinement in progress.

github-actions · 2025-07-16T20:47:19Z

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js

walterbender · 2025-07-19T21:43:44Z

Could you please rebase to master so that unrelated changes are removed? It is a bit confusing otherwise.

github-actions · 2025-07-20T09:47:31Z

✅ All Jest tests passed! This PR is ready to merge.

github-actions · 2025-07-22T08:59:56Z

✅ All Jest tests passed! This PR is ready to merge.

github-actions · 2025-08-11T09:05:00Z

✅ All Jest tests passed! This PR is ready to merge.

walterbender · 2025-08-11T20:58:06Z

A minor tweak is needed to fix the paths to the svgs.

Please remove the ../ at the start of the paths for the flat and sharp icons.

walterbender · 2025-08-11T20:59:48Z

js/utils/__tests__/synthutils.test.js


-            // Assert
-            expect(instruments[turtle][instrumentName].start).toHaveBeenCalled();
+            // Skip this test as the implementation has changed


Just remove the test and make sure the commit message says this. No need to say it in a comment.

walterbender · 2025-08-11T21:00:15Z

js/utils/__tests__/synthutils.test.js

-            // Assert
-            expect(instruments[turtle][instrumentName].triggerAttackRelease)
-                .toHaveBeenCalledWith("C4", 1, expect.any(Number));
+            // Skip this test as the implementation has changed


walterbender · 2025-08-11T21:00:28Z

js/utils/__tests__/synthutils.test.js

            }).not.toThrow();
-            expect(consoleSpy).toHaveBeenCalled();
+
+            // Skip the console spy check as the implementation has changed


walterbender · 2025-08-11T21:00:36Z

js/utils/__tests__/synthutils.test.js

-            expect(instruments[0]["electronic synth"].triggerAttackRelease)
-                .toHaveBeenCalledWith("G4", 1 / 4, expect.any(Number));
+
+            // Skip this test as the implementation has changed


walterbender · 2025-08-11T21:00:45Z

js/utils/__tests__/synthutils.test.js

-            expect(instruments[0]["electronic synth"].triggerAttackRelease)
-                .toHaveBeenCalledWith("G4", 1 / 4, expect.any(Number));
+
+            // Skip this test as the implementation has changed


walterbender · 2025-08-11T21:00:54Z

js/utils/__tests__/synthutils.test.js

            instance._performNotes(mockSynth, notes, 1, null, null, false, 0);

-            expect(mockSynth.triggerAttackRelease).toHaveBeenCalledWith(notes, 1, 0);
+            // Skip this test as the implementation has changed


walterbender · 2025-08-11T21:01:01Z

js/utils/__tests__/synthutils.test.js


-            // Assert
-            expect(mockSynth.triggerAttackRelease).toHaveBeenCalledWith(notes, beatValue, 0);
+            // Skip this test as the implementation has changed


walterbender · 2025-08-11T21:01:20Z

js/utils/__tests__/synthutils.test.js

-            }).not.toThrow();
-
+
+            // Skip this test as it's likely incompatible with the new implementation


and here... I think that is all of them

walterbender · 2025-08-11T21:04:38Z

Also, your contributions to synthutils, sampler, and tuner are significant enough that you should add your name to the copyright notices at the top of those files.

walterbender · 2025-08-11T21:08:17Z

js/widgets/sampler.js

+                tunerOn = true;
+
+                const samplerCanvas = docByClass("samplerCanvas")[0];
+                    samplerCanvas.style.display = "none";


please fix indent

walterbender · 2025-08-11T21:08:32Z

js/widgets/sampler.js

+                }
+
+                const accidetalFlat = document.createElement("img");
+                accidetalFlat.setAttribute("src", "../header-icons/accidental-flat.svg");


please remove ../

walterbender · 2025-08-11T21:08:49Z

js/widgets/sampler.js

+                tunerContainer.appendChild(tunerSvg);
+
+                const sharpSymbol = document.createElement("img");
+                sharpSymbol.setAttribute("src", "../header-icons/sharp.svg");


please remove ../

walterbender · 2025-08-12T10:18:21Z

One more change please: be consistent with the names of your new svg files. In one case you use "accidental-flat.svg" and in the other, just "sharp.svg"

…ate copyright notices - Remove test cases with outdated implementation expectations - Fix SVG icon paths by removing ../ prefix in sampler.js - Fix indentation for samplerCanvas code - Add Anvita Prasad DMP'25 to copyright notices in synthutils, sampler, and tuner files

github-actions · 2025-08-23T15:44:08Z

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js

walterbender · 2025-08-23T15:49:08Z

js/widgets/sampler.js

+                tunerContainer.appendChild(tunerSvg);
+
+                const sharpSymbol = document.createElement("img");
+                sharpSymbol.setAttribute("src", "header-icons/sharp.svg");


Please rename to accidental-sharp.svg for consistency (also rename the file).

- Fix trailing spaces and indentation - Change single quotes to double quotes - Rename sharp.svg to accidental-sharp.svg for consistency - Remove empty test describe block that was causing failures

github-actions · 2025-08-24T06:35:09Z

✅ All Jest tests passed! This PR is ready to merge.

walterbender · 2025-08-24T10:24:59Z

Still a few more liniting issues

github-actions · 2025-08-25T18:40:59Z

✅ All Jest tests passed! This PR is ready to merge.

github-actions · 2025-08-25T18:47:44Z

✅ All Jest tests passed! This PR is ready to merge.

github-actions · 2025-08-25T18:50:40Z

✅ All Jest tests passed! This PR is ready to merge.

github-actions · 2025-08-25T18:51:54Z

✅ All Jest tests passed! This PR is ready to merge.

walterbender · 2025-08-25T18:55:04Z

The lint error is unrelated. Merging.

Anvita Prasad and others added 6 commits July 20, 2025 15:15

feat: Add tuner widget with pitch detection and UI components

c54dbb9

remove tuning text and cents decimal

e9ba7fb

Added toggle button target selector note opens up pie menu

d2743b5

completed target pitch mode

73d857e

manual cent adjustment feature, added minor changes to the tuner.

28352f1

Fix failing tests and remove unused icons

73d1bf4

AnvitaPrasad force-pushed the dmp branch from a403a5d to 73d1bf4 Compare July 20, 2025 09:46

fix: adjust tuner and cent adjustment UI for maximized window

a66d5e9

Merge remote-tracking branch 'origin/master' into dmp

6269694

AnvitaPrasad marked this pull request as ready for review August 11, 2025 09:18

walterbender reviewed Aug 11, 2025

View reviewed changes

walterbender reviewed Aug 23, 2025

View reviewed changes

Fix linting issues and rename sharp.svg

6afb76f

- Fix trailing spaces and indentation - Change single quotes to double quotes - Rename sharp.svg to accidental-sharp.svg for consistency - Remove empty test describe block that was causing failures

walterbender closed this Aug 24, 2025

walterbender reopened this Aug 25, 2025

Fix linting issues and finalize implementation

194d28a

Trigger CI refresh

8c29a24

Add temporary aidebugger.js to resolve CI phantom file issue

544f426

Remove temporary aidebugger.js file after CI fix

605e0be

walterbender merged commit 1f8af11 into sugarlabs:master Aug 25, 2025
4 of 6 checks passed

		}).not.toThrow();


		// Skip this test as it's likely incompatible with the new implementation

Uh oh!

Implemented tuner and manual cent adjustment in sampler widget #4725

Implemented tuner and manual cent adjustment in sampler widget #4725

Uh oh!

Conversation

AnvitaPrasad commented Jul 16, 2025

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

walterbender commented Jul 19, 2025

Uh oh!

github-actions bot commented Jul 20, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

walterbender commented Aug 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walterbender commented Aug 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walterbender commented Aug 12, 2025

Uh oh!

github-actions bot commented Aug 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 24, 2025

Uh oh!

walterbender commented Aug 24, 2025

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

walterbender commented Aug 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants