Skip to content

Conversation

@Nalin-khanna
Copy link

I have tested the jQuery migration using the jQuery migrate plug-in .
The console warnings were originating from jquery-ui file , as we were using an older version of it (v1.11.4) .
I replaced it with jQuery - UI v1.14.1 (currently stable). This resolved the console warnings from jQuery migrate.
I have updated sw.js and cache.appcache to precache the new filename and updated script tag to point to new file.

  • Unit tests pass
  • Site behavior remains unchanged after upgrade

this closes #4682

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2025

✅ All Jest tests passed! This PR is ready to merge.

@Nalin-khanna
Copy link
Author

@Ubayed-Bin-Sufian can I get a review ?

@Ubayed-Bin-Sufian
Copy link
Contributor

@Ubayed-Bin-Sufian can I get a review ?

Thanks for creating the PR. Hopefully, the maintainers would review it. Please have patience.

@walterbender
Copy link
Member

Can you please check search? It doesn't seem to work for me.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@Nalin-khanna
Copy link
Author

Can you please check search? It doesn't seem to work for me.

I wasn't able to resolve this issue. After upgrading the jQuery UI file, the doSearch function seems to be getting called before it's available, likely a timing or loading order issue. It was previously undefined too, but now it's more consistent.

@Ubayed-Bin-Sufian
Copy link
Contributor

@Nalin-khanna The doSearch issue is an old one. #2618 can shed some light. You may have a look.

@Nalin-khanna
Copy link
Author

@Nalin-khanna The doSearch issue is an old one. #2618 can shed some light. You may have a look.

thanks ! I'll have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade jQuery from version 2.1.4 to 3.7.1

3 participants