-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Color Detector For music Blocks. #4596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
I think it should also work without pen up block in the forever block, otherwise looks good. |
|
testing.webm |
|
I was testing on Firefox. I'll try again on Chrome. |
|
@FirePheonix i m not sure if i m doing it right or wrong but this actually did not works for me too but will try again |
Please share the screenshot, also which browser are you using. |
That i understand about failure but it is always suggested to do change the failed tests and refactor or add the new test for new function within the PR itself that's what i m suggesting |
|
@omsuneri I think first code should be finalized and if no more changes are required then only we should change the test. I hope you understand. |
|
@omsuneri @haroon10725 Yes, I've been working on this PR for a while now. Code will be finalized , writing and checking test case for it will be done by tomorrow. |
I've now tested it on Firefox browser as well, here's the demo:Music.Blocks.Mozilla.Firefox.2025-04-07.07-13-52.mp4And here's the working of THE IMAGE block for detection of real time photos:hihihi.mp4 |
|
Any theory as to why it didn't work for me? I'll try again. |
|
@walterbender as you requested, here's the MB project I created to continuously detect pixel colors underneath the image uploaded. |
|
@walterbender it's strange previously it works for me but now it's not working :/ |
|
Nope. I still cannot get it to work (tested in Chromium from a local server). Got -1 everywhere I moved the cursor. |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
@FirePheonix Let us know once this is ready to test again. |
|
@pikurasa Alrightttt. |
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
|
@sa-fw-an could you test it on mac? |
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
|
Closed pull request due to inactivity for more than 63 days. |
|
Closed pull request due to inactivity for more than 63 days. |


Existing music blocks functionality:
A range of colours is mapped onto a different number
What does this PR do?
Adding color detection on image uploaded to canvas by show block with the help of media block. (DONE)
Music.Blocks.-.Google.Chrome.2025-03-29.08-11-33.1.mp4
This PR will be of much in future development purposes.