Skip to content

Conversation

@FirePheonix
Copy link
Contributor

@FirePheonix FirePheonix commented Mar 31, 2025

Existing music blocks functionality:

  1. Read Color drawn by the mouse glyph on the canvas of MB.
    A range of colours is mapped onto a different number

What does this PR do?

Adding color detection on image uploaded to canvas by show block with the help of media block. (DONE)

Music.Blocks.-.Google.Chrome.2025-03-29.08-11-33.1.mp4

This PR will be of much in future development purposes.

@github-actions
Copy link
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

SensorsBlocks.test.js

@haroon10725
Copy link
Contributor

I think it should also work without pen up block in the forever block, otherwise looks good.
@walterbender @pikurasa What do you think about it.

@walterbender
Copy link
Member

Testing. It doesn't seem to work for me.

Screenshot From 2025-04-01 09-44-11

Every pixel returns 50.

@haroon10725
Copy link
Contributor

haroon10725 commented Apr 1, 2025

testing.webm
@walterbender I think it is a browser issue. Working fine on Chrome

@walterbender
Copy link
Member

I was testing on Firefox. I'll try again on Chrome.

@omsuneri
Copy link
Member

omsuneri commented Apr 2, 2025

@FirePheonix i m not sure if i m doing it right or wrong but this actually did not works for me too but will try again
also why the test is getting failed for this

@haroon10725
Copy link
Contributor

@FirePheonix i m not sure if i m doing it right or wrong but this actually did not works for me too but will try again
also why the test is getting failed for this

Please share the screenshot, also which browser are you using.
Test is being failed because functionality has been changed and tests were written for old functionality.

@omsuneri
Copy link
Member

omsuneri commented Apr 2, 2025

@FirePheonix i m not sure if i m doing it right or wrong but this actually did not works for me too but will try again
also why the test is getting failed for this

Please share the screenshot, also which browser are you using. Test is being failed because functionality has been changed and tests were written for old functionality.

That i understand about failure but it is always suggested to do change the failed tests and refactor or add the new test for new function within the PR itself that's what i m suggesting

@haroon10725
Copy link
Contributor

@omsuneri I think first code should be finalized and if no more changes are required then only we should change the test. I hope you understand.

@FirePheonix
Copy link
Contributor Author

@omsuneri @haroon10725 Yes, I've been working on this PR for a while now. Code will be finalized , writing and checking test case for it will be done by tomorrow.

@FirePheonix
Copy link
Contributor Author

@walterbender

I've now tested it on Firefox browser as well, here's the demo:

Music.Blocks.Mozilla.Firefox.2025-04-07.07-13-52.mp4

And here's the working of THE IMAGE block for detection of real time photos:

hihihi.mp4

@FirePheonix FirePheonix marked this pull request as ready for review April 7, 2025 02:13
@walterbender
Copy link
Member

Any theory as to why it didn't work for me? I'll try again.

@FirePheonix
Copy link
Contributor Author

@walterbender as you requested, here's the MB project I created to continuously detect pixel colors underneath the image uploaded.
Music Blocks — Mozilla Firefox 07-04-2025 20_05_30

@omsuneri
Copy link
Member

omsuneri commented Apr 7, 2025

@walterbender it's strange previously it works for me but now it's not working :/
With no logs

@walterbender
Copy link
Member

Nope. I still cannot get it to work (tested in Chromium from a local server). Got -1 everywhere I moved the cursor.

@github-actions
Copy link
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

SensorsBlocks.test.js

@pikurasa
Copy link
Collaborator

@FirePheonix Let us know once this is ready to test again.

@FirePheonix
Copy link
Contributor Author

@pikurasa Alrightttt.

@github-actions
Copy link
Contributor

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Jun 30, 2025
@FirePheonix
Copy link
Contributor Author

@sa-fw-an could you test it on mac?

@github-actions github-actions bot removed the Stale label Jul 1, 2025
@github-actions
Copy link
Contributor

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Aug 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions bot closed this Sep 4, 2025
@walterbender walterbender reopened this Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions bot closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants