-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test suite for js/midi #4465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test suite for js/midi #4465
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Also in the previous PR for midi I forgot to correct the MAX_NOTEBLOCKS constant back to 100. |
|
Hmm. I am seeing an error now with the midi section of the Save interface test. FAIL js/tests/SaveInterface.test.js |
|
@walterbender Sir, you may have to install this module. You can do an That's why I think tests are passing in GitHub Actions |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
OK. It should already be installed on the master branch. |


@walterbender I have made tests for midi file. I brought
getClosestStandardNoteValueto midi.js as it is solely used by it. This will improve maintenance and make it easier to write test cases.Please review this PR.