test suite for the js/blocks/DictBlocks.js #4464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
Author
|
@walterbender i m happy to see that our workflow for test is running great also do we need another for syntax and linting or should i improve the old eslint with some updates and new features what would you say ?? |
Member
|
If we can get away with eslint, I think we are OK for now. |
Member
Author
fine i ll try to look into the eslint let see if what can i do in that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@walterbender I had created test suite for the js/blocks/DictBlocks.js
