test suite for js/js-export/constraints.js #4458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
Author
|
@walterbender i had resolved all the conflicts which you suggested again i know some of the constraints are really not neccessary like the limit to play notes but i assume constraints.js to be at the higest level if you want i can update some of the limits which you encountered as weird in the constraints.js |
Member
|
I am not sure why some of these constraints were put into the js-export code. I think they are over-zealous. But maybe we leave them as is for the purposes of this test and open a ticket to revisit them in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@walterbender i had created a test suite for js/js-export/constraints.js please review this.
