Fix Navbar Icon Height Issue on Responsive Screens #4448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Not sure we want to do this. We've had a regression, but the icons were shrinking to fit previously. |
Author
Sure , i'll fix this ASAP and raise another PR . |
Contributor
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
Contributor
|
Closed pull request due to inactivity for more than 63 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where the height of icons in the navbar would change when the screen width was minimized or maximized. The expected behavior is for the icons to maintain a consistent height across all screen sizes.
Changes made:
Added CSS Flexbox to ensure consistent height for navbar icons.
Applied media queries to maintain icon height across different screen widths.
Ensured compatibility with Bootstrap classes, if applicable.
This update resolves the issue and ensures a uniform appearance for the navbar icons on all devices.
#4351