Skip to content

refactor: remove extra code and fix formatting #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

refactor: remove extra code and fix formatting #4442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
806e9ae
update sampler.js
haroon10725 Feb 21, 2025
0477d2c
add space between +
haroon10725 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions js/widgets/sampler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,23 +305,21 @@ function SampleWidget() {
const reader = new FileReader();
reader.readAsDataURL(sampleFile);

reader.onload = () =>{
reader.onload = () => {
// if the file is of .wav type, save it
if (reader.result.substring(reader.result.indexOf(":")+1, reader.result.indexOf(";")) === "audio/wav"){
if (reader.result.length <= 1333333){
if (reader.result.substring(reader.result.indexOf(":") + 1, reader.result.indexOf(";")) === "audio/wav") {
if (reader.result.length <= 1333333) {
this.sampleData = reader.result;
this.sampleName = sampleFile.name;
this._addSample();
}
else{
} else {
this.activity.errorMsg(_("Warning: Your sample cannot be loaded because it is >1MB."), this.timbreBlock);
}
}
// otherwise, output error message
else{
} else {
this.showSampleTypeError();
}
}

reader.onloadend = () => {
if (reader.result) {
const value = [sampleFile.name, reader.result];
Expand All @@ -335,20 +333,13 @@ function SampleWidget() {

dropZone.addEventListener("dragover", (e) => {
e.preventDefault();
dropZone.classList.add("dragover");
})

dropZone.addEventListener("dragleave", () => {
dropZone.classList.remove("dragover");
})
});

dropZone.addEventListener( "drop", (e) => {
e.preventDefault();
dropZone.classList.remove("dragover");

const sampleFiles = e.dataTransfer.files[0];
this.handleFiles(sampleFiles);
})
});
}

/**
Expand Down
Loading