Fixed Tests for Turtle Singer and Synth Utils

[ac-mmi]

This PR fixes issues with the tests for TurtleSinger, SynthUtils, and VolumeActions which i saw in my previous PR. There were some errors popping up due to undefined properties and some inconsistent mocks, so I cleaned that up.

In turtle-singer.test.js, I fixed TypeErrors by properly setting up blockList and connections. I also improved the mocking for Tone.Panner and updated test cases to cover more edge cases. In synthutils.test.js, I resolved issues with mocks causing errors and initialized activity.logo.synth correctly to avoid undefined errors.

In volumeactions.test.js, I fixed undefined connections by setting up blockList as follows:

blockList: {
       mockBlk: {
         connections: ['mockConnection1', 'mockConnection2']
         }
}

I ran the npm test command, and all the tests passed.

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

[omsuneri]

@ac-mmi try to look at the #4422 as this PR resolves all the errors of volumeaction also you are not supposed to make changes in the root file also try to folow our guide for implementing tests also i observed that you had changed multiple po files which need to be done in another PR

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

[ac-mmi]

@omsuneri i have removed those po files. The changes that i have done in the root file in turtle-singer.js was this line
const lastConnection = activity.logo.blockList[blk].connections.slice(-1)[0] || null;
where earlier it used last() function but when i ran test case i got last() as undefined function.

[ac-mmi]

#4422 (comment)
@walterbender I added the following to activityMock to ensure that setMasterVolume receives the first and last connection arguments correctly:

blockList: {
    mockBlk: {
        connections: ['mockConnection1', 'mockConnection2']
    }
}

I also updated the tests to ensure setMasterVolumeand setSynthVolume are called with the correct arguments.

test('should set master volume correctly', () => {
    Singer.setMasterVolume(logoMock, 50, 'mockBlk');
    expect(logoMock.synth.setMasterVolume).toHaveBeenCalledWith(50, 'mockConnection1', 'mockConnection2');
});

test('should set synth volume correctly', () => {
    Singer.setSynthVolume(logoMock, turtleMock, 'noise1', 80, 'mockBlk');
    expect(logoMock.synth.setVolume).toHaveBeenCalledWith(turtleMock, 'noise1', 80 / 25, 'mockBlk');
});

[omsuneri]

@ac-mmi try to mock the last as global.last = jest.fn((array) => array[array.length - 1]);
before the import of require

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

[omsuneri]

@ac-mmi also try to remove the volumaction part as well as those errors are removed in the #4422 and also there i had added many new tests so kindly please do that tooo else it will create a conflict between that

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

[ac-mmi]

@omsuneri Done

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

[omsuneri]

@ac-mmi you dont need to merge the chnages of #4422 in your PR just simply remove the chnages you done for volumeaction.js and volumeaction.test.js dont copy those changes here
also try keep branch clean.
hope you understand my comment. !!

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

[ac-mmi]

@omsuneri Alright i will take care of this in future

[omsuneri]

@ac-mmi no issues now this looks good !!

[walterbender]

please remove the unnecessary comments, such as // New additon

[walterbender]

What are the .po.tmp files for?

[ac-mmi]

@walterbender The .po.tmp files are simplified versions of the .po files with just the msgid and msgstr values, without any comments or extra details. I noticed this when working on PR #4433 , where I fixed an issue with "gong" word in quz.po. It had an empty msgstr, and the .tmp file stopped processing at that point. I think it’s meant to make processing easier but might get stuck on problematic entries.

[walterbender]

Please make any changes to PO files in a separate PR. Also, the comments in the PO files are there to help the translators.

[ac-mmi]

@walterbender, I noticed the PR got closed, and I’m not sure why. Could you let me know the reason? I’d like to understand so I can learn from it and improve. If possible, I’d like to continue working on this. Thanks!

[walterbender]

It was closed by accident. Sorry about that. Fat fingers today.

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

VolumeActions.test.js

[ac-mmi]

@walterbender no problem

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

VolumeActions.test.js

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

VolumeActions.test.js

[github-actions]

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

VolumeActions.test.js