-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Refactor webL10n.js for Improved Readability and Maintainability #4435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ency and readability
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
Can you make this two separate PRs? I will merge the changes to localization.ini right away... but we should discuss the changes to webi10n.js. That is an external library which we probably want to maintain upstream. But also, we are thinking about replacing it all together. |
|
Got it! I will close this PR and open two separate ones as requested. Thanks for the clarification! |
Description
This pull request refactors the webL10n.js file to improve readability and maintainability. The following changes have been made: