Skip to content

Conversation

@Ashrafmuhmed
Copy link
Contributor

Description

This pull request refactors the webL10n.js file to improve readability and maintainability. The following changes have been made:

  • Fixed formatting (spacing, indentation).
  • Renamed unclear variables for better understanding.
  • Split large functions into smaller, reusable ones.
  • fix localization strings for motion-y and get-protein in Arabic

@github-actions
Copy link
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

@walterbender
Copy link
Member

Can you make this two separate PRs? I will merge the changes to localization.ini right away... but we should discuss the changes to webi10n.js. That is an external library which we probably want to maintain upstream. But also, we are thinking about replacing it all together.

@Ashrafmuhmed
Copy link
Contributor Author

Got it! I will close this PR and open two separate ones as requested. Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants