Skip to content

Conversation

@justin212407
Copy link
Member

Description:

This PR addresses issue #4429 and fixes UI issues in dark mode affecting the grid, dialog box, and dropdown.

Changes Made:

Fixed grid and dialog box styling to ensure proper visibility in dark mode.
Adjusted background and text colors to match the dark theme.

Screenshots:

image

image

image

Checklist:

  • The code has been tested in Dark Mode.
  • There are no breaking changes.

Signed-off-by: Justin Charles <[email protected]>
@justin212407
Copy link
Member Author

@walterbender please review this

@walterbender
Copy link
Member

These are all good. But the grid itself is still a bit off.
Screenshot From 2025-02-17 21-28-57

@justin212407
Copy link
Member Author

Ohh i guess it got overlooked i'll fix that and push that commit too

@walterbender
Copy link
Member

walterbender commented Feb 23, 2025

The grids are rendered with this method:

https://github.com/sugarlabs/musicblocks/blob/master/js/activity.js#L2438

But the individual grid SVGs are defined in artwork.js
It is there that you could replace the color (fill and stroke) definitions with entities that get "replaced" before doing the b64 conversion in, for example, https://github.com/sugarlabs/musicblocks/blob/master/js/activity.js#L6689

@justin212407
Copy link
Member Author

Sure i will take a look into it and make all the neccessary changes and then update this pr

@github-actions
Copy link
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

synthutils.test.js
VolumeActions.test.js
turtle-singer.test.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants